Create dependency between cluster issuers and cert-manager #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cluster issuer resources depend on a customer resource definition supplied by the cert-manager chart, but they did not previously depend on that chart being created first. Unfortunately, that alone doesn't allow deployment to happen since the `kubernetes_manifest` resource type attempts to validate the resource type at plan time, when the CRD is not yet installed. This could only be fixed by moving the deployment of resources into a completely independent deployment (even a submodule doesn't help). The `kubectl` provider also provides a "manifest" resource type, which does not very the resource types at plan time. Using this instead allows planning to complete.
ekadas
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
522317c fix: create dependency between cluster issuers and cert-manager
The cluster issuer resources depend on a customer resource definition
supplied by the cert-manager chart, but they did not previously depend
on that chart being created first.
Unfortunately, that alone doesn't allow deployment to happen since the
kubernetes_manifestresource type attempts to validate the resourcetype at plan time, when the CRD is not yet installed. This could only
be fixed by moving the deployment of resources into a completely
independent deployment (even a submodule doesn't help).
The
kubectlprovider also provides a "manifest" resource type, whichdoes not very the resource types at plan time. Using this instead allows
planning to complete.