Vcoman/keep ble #76
Open
Vcoman/keep ble #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Coman <[email protected]>
- Before when you pressed the button, it was switching between simulation and real data. - Now it always works with real data, and the button just toggles the electronic water valve to open or close. Signed-off-by: Victor Coman <[email protected]>
…nd turns off when closed) Signed-off-by: Victor Coman <[email protected]>
| @@ -299,7 +299,7 @@ def relay_frame_callback(relay_frame): | |||
| elif operation == OP_FINISH: | |||
| print("- BLE: Finish request received.") | |||
| # Disable BLE interface. This operation does not require a response. | |||
| xbee.atcmd(AT_CMD_BT, VALUE_DISABLED) | |||
| # xbee.atcmd(AT_CMD_BT, VALUE_DISABLED) | |||
There was a problem hiding this comment.
This should be removed instead of commented out.
| valve_pos = 0 | ||
|
|
||
| print("- Toggling valve status to '{}'.".format("Open" if valve_pos == 1 else "Closed")) | ||
| # set_valve_open(new_status) |
hgonzaleDigi
approved these changes
Dec 21, 2021
diescalo
approved these changes
Dec 21, 2021
Signed-off-by: Ruben Moral <[email protected]>
rubenmoral
force-pushed
the
vcoman/keep_ble
branch
from
d0a1c94 to
046ebe2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.