Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make ajv a dev dep #264

Merged
merged 1 commit into from
Sep 17, 2024
Merged

chore: make ajv a dev dep #264

merged 1 commit into from
Sep 17, 2024

Conversation

gmaclennan
Copy link
Member

Now that we vendor ucs2length, ajv is not needed at runtime

@gmaclennan
chore: make ajv a dev dep
6a4b617 
Now that we vendor ucs2length, ajv is not needed at runtime
@gmaclennan gmaclennan self-assigned this Sep 17, 2024
@gmaclennan gmaclennan requested a review from EvanHahn September 17, 2024 00:00
gmaclennan
gmaclennan commented Sep 17, 2024
View reviewed changes
Copy link
Member Author

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ajv at runtime was causing react native to crash

@EvanHahn EvanHahn merged commit d5a903d into main Sep 17, 2024
6 checks passed
@EvanHahn EvanHahn deleted the chore/ajv-to-dev-dep branch September 17, 2024 14:58
@optic-release-automation optic-release-automation bot mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanHahn EvanHahn EvanHahn approved these changes

Assignees

@gmaclennan gmaclennan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmaclennan @EvanHahn