Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: standardize usage of config files #898

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Dec 18, 2024

The unofficial convention for configuring different tooling has moved towards having a file named <name>.config.js for each tool that supports it. In most cases, tools support a variety of configuration approaches but in general, I prefer using a config file when possible because it allows for types-based checking + assistance when writing/updating the configuration, which is massively useful.

This PR does the following:

  • ports the jest configuration from package.json to jest.config.js
  • ports the lint-staged configuration from package.json to lint-staged.config.js
  • ports the prettier configuration from .prettierrc.js to prettier.config.js

ESLint is notably omitted here because it requires upgrading to v9 in order to use this config file convention. That work is addressed via #897

@achou11 achou11 force-pushed the ac/standardize-config-files branch from b59a6d6 to f6f2fca Compare December 18, 2024 22:50
@achou11 achou11 requested a review from ErikSin December 18, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant