feat: Tracks saving #271

CDFN · 2024-04-22T14:35:35Z

This PR adds hooks for backend communication and implements tracks saving.

Closes #239

…sion

…ing button

…sion

…ing button

…nto feat/save-track

…eet modal, and fixed padding in discription input

achou11

My previous comment about the custom navigation header that's used in the save tracks screen seems to have been overlooked. that's probably the biggest blocker on my end right now.

Also had a UX question about something i ran into when testing this in the app.

achou11 · 2024-04-29T18:41:55Z

src/frontend/screens/MapScreen/track/saveTrack/SaveTrackHeader.tsx

@CDFN @bohdanprog highlighting this in case this got lost in the first review

EDIT: Github does a terrible job of re-surfacing this, so adding the direct comment link

src/frontend/screens/MapScreen/GPSPermissions/GPSPermissionsEnabled.tsx

ErikSin

~~Besides my 2 comments, and andrew's comments, looks good to me.~~

~~I have noticed some architecture changes related to the location provider that I think we need to revert, but I will create an issue for that.~~

I realize that we are not persisting the tracks (after the track has been taken). I added a comment below

src/frontend/hooks/tracks/useTracking.ts

ErikSin · 2024-04-30T03:07:25Z

src/frontend/screens/MapScreen/track/SaveTrackScreen.tsx

+  navigation,
+}) => {
+  const {formatMessage: t} = useIntl();
+  const [description, setDescription] = useState('');


We want to persist the description in case the user closes their phone. instead of using setDescription use updateTags('notes', newVal); and instead of description use const notes = usePersistedDraftObservation(store => store.value?.tags.notes)

ErikSin · 2024-04-30T03:44:28Z

If the user has stopped "tracking" but is in the middle of saving it (aka they are on SaveTrackScreen) and they close the app, we want to make sure it opens again on the saveTrackScreen, and that the tracks are persisted in state. In observations acheive this by saving observations in persisted state.

We should follow a similar pattern with tracks. Instead of saving locationHistory to plain zustand state we should save it to persisted state.

Also, when the app open we want to do a check to see if locationHistory exists in persisted state, and if it does, open the SaveTrackScreen.

^^When we do this changes the navigation behaviour. When the hit save, they will be navigated to the map. But the user will now be able to press the back button and go back to the saveTrackScreen. So we need to prevent this by resetting the nav stack on save.

src/frontend/screens/MapScreen/track/SaveTrackScreen.tsx

src/frontend/screens/MapScreen/track/saveTrack/DiscardTrackModal.tsx

…hook

…instead custom header

achou11 · 2024-04-30T17:06:45Z

If the user has stopped "tracking" but is in the middle of saving it (aka they are on SaveTrackScreen) and they close the app, we want to make sure it opens again on the saveTrackScreen, and that the tracks are persisted in state. In observations acheive this by saving observations in persisted state.

We should follow a similar pattern with tracks. Instead of saving locationHistory to plain zustand state we should save it to persisted state.

Also, when the app open we want to do a check to see if locationHistory exists in persisted state, and if it does, open the SaveTrackScreen.

^^When we do this changes the navigation behaviour. When the hit save, they will be navigated to the map. But the user will now be able to press the back button and go back to the saveTrackScreen. So we need to prevent this by resetting the nav stack on save.

@ErikSin thoughts on this being a follow-up to this PR? The scope of changes required to get the above working might be large enough to warrant a separate PR to make it easier to review. Not sure if @CDFN @bohdanprog have already started making changes here towards that but if they haven't, would put it into consideration

ErikSin · 2024-04-30T17:09:45Z

@ErikSin thoughts on this being a follow-up to this PR? The scope of changes required to get the above working might be large enough to warrant a separate PR to make it easier to review. Not sure if @CDFN @bohdanprog have already started making changes here towards that but if they haven't, would put it into consideration

Yeah, that sounds good. I do think we should do this sooner, rather than later as it will effect the subsequent Pr, but I think separating it makes sense.

achou11 · 2024-04-30T17:24:54Z

Yeah, that sounds good. I do think we should do this sooner, rather than later as it will effect the subsequent Pr, but I think separating it makes sense.

yeah agreed - would it be helpful to create an issue that details the needed changes that Erik described @CDFN @bohdanprog ?

CDFN · 2024-04-30T17:35:59Z

I got some changes but it's fairly easy to move it to another branch. For issue, would be great to summarize it there if you could.

CDFN · 2024-04-30T18:38:12Z

@achou11 does this mean we should merge this one and work on #306 right after? Or just merge #306 into feat/save-track and then merge this pr into main?

achou11 · 2024-04-30T18:40:13Z

@achou11 does this mean we should merge this one and work on #306 right after? Or just merge #306 into feat/save-track and then merge this pr into main?

The first option is what I would suggest, so you aren't doing too much branch managing :)

achou11

Can this comment about the navigation header be addressed before merging?

Otherwise changes seem ready for merging :)

…nto feat/save-track

bohdanprog · 2024-04-30T19:25:42Z

Can this comment about the navigation header be addressed before merging?

Otherwise changes seem ready for merging :)

Hm...but I already changed Header in SaveTrackScreen :D

Here is a link :)
https://github.com/digidem/comapeo-mobile/pull/271/files#diff-26c6b74f7f8821ec00c3bbe4c3af65fc469d5d9aca1500e13eeec62733009ea9R95

ErikSin · 2024-04-30T19:45:23Z

Im going to merge this as I have a PR stacked on this, and I would like to create another PR based on this

CDFN and others added 30 commits April 11, 2024 10:25

wip nav changes to allow displaying modal without changing screen

77245ee

add custom tab bar icon and label

2ba1cea

add modal with different options

733746e

tracks poc

6bd0461

add check if permission granted, add function to request about permis…

1f597d7

…sion

add animation, add function for check permission disable strart track…

bef576b

…ing button

wip nav changes to allow displaying modal without changing screen

d9dfbde

add custom tab bar icon and label

9620c12

add modal with different options

1d8da9e

tracks poc

7245fe7

add check if permission granted, add function to request about permis…

8773faf

…sion

add animation, add function for check permission disable strart track…

dfa1791

…ing button

fixed problem with custom modal

dee33fd

merged

94db2fa

fix hooks dependencies, user location flick

5e338f7

cleanup

e145973

place observations exactly at track line

5cfeb75

store observations found on track

8d398c5

add check if foreground permission is granted, add gps indicator

82b5c5c

move gps indicator to map header

d3c53ea

create custom bottom sheet component with clicalbe backdrop

9d125b0

add icon to start tracking and stop tracking button

f1b7ede

fix hooks dependencies, user location flick

804f42b

cleanup

d56b2b5

place observations exactly at track line

02bab4b

store observations found on track

f8b2a3a

add check if foreground permission is granted, add gps indicator

b35b1ec

move gps indicator to map header

577c6db

fix bug where observations don't display when there's no tracking line

07f8662

cleanup track store naming

44aae30

bohdanprog and others added 3 commits April 28, 2024 12:19

Merge branch 'feat/save-track' of github.com:digidem/CoMapeo-mobile i…

6854969

…nto feat/save-track

bring back feature flag, remove unnecessary checks

b4afdbe

fixed issue with discard track modal, using already created bottom sh…

8a47fdf

…eet modal, and fixed padding in discription input

achou11 requested changes Apr 29, 2024

View reviewed changes

ErikSin approved these changes Apr 30, 2024

View reviewed changes

ErikSin reviewed Apr 30, 2024

View reviewed changes

src/frontend/screens/MapScreen/track/SaveTrackScreen.tsx Show resolved Hide resolved

ErikSin reviewed Apr 30, 2024

View reviewed changes

src/frontend/screens/MapScreen/track/saveTrack/DiscardTrackModal.tsx Outdated Show resolved Hide resolved

bohdanprog added 4 commits April 30, 2024 09:30

create share component DiscardModal, fixed dependency in useTracking …

c20cb74

…hook

add edit track screen, add update track method

b19e32b

add edit track screen, add update track method

0fa31af

add back handler on Save Track Screen

524b58a

digidem deleted a comment from expo bot Apr 30, 2024

bohdanprog and others added 2 commits April 30, 2024 15:21

changed save track screen, using header from react-native-navigation …

af009b0

…instead custom header

Merge branch 'main' into feat/save-track

d73fdba

achou11 mentioned this pull request Apr 30, 2024

Tracks saving flow should persist #306

Closed

3 tasks

achou11 requested changes Apr 30, 2024

View reviewed changes

Merge branch 'feat/save-track' of github.com:digidem/CoMapeo-mobile i…

d2da3c7

…nto feat/save-track

achou11 approved these changes Apr 30, 2024

View reviewed changes

ErikSin merged commit 0359735 into main Apr 30, 2024
3 checks passed

ErikSin deleted the feat/save-track branch April 30, 2024 19:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Tracks saving #271

feat: Tracks saving #271

CDFN commented Apr 22, 2024

achou11 left a comment

achou11 Apr 29, 2024 •

edited

Loading

ErikSin left a comment •

edited

Loading

ErikSin Apr 30, 2024 •

edited

Loading

ErikSin commented Apr 30, 2024

achou11 commented Apr 30, 2024 •

edited

Loading

ErikSin commented Apr 30, 2024

achou11 commented Apr 30, 2024

CDFN commented Apr 30, 2024

CDFN commented Apr 30, 2024

achou11 commented Apr 30, 2024

achou11 left a comment

bohdanprog commented Apr 30, 2024 •

edited

Loading

ErikSin commented Apr 30, 2024

feat: Tracks saving #271

feat: Tracks saving #271

Conversation

CDFN commented Apr 22, 2024

achou11 left a comment

Choose a reason for hiding this comment

achou11 Apr 29, 2024 • edited Loading

Choose a reason for hiding this comment

ErikSin left a comment • edited Loading

Choose a reason for hiding this comment

ErikSin Apr 30, 2024 • edited Loading

Choose a reason for hiding this comment

ErikSin commented Apr 30, 2024

achou11 commented Apr 30, 2024 • edited Loading

ErikSin commented Apr 30, 2024

achou11 commented Apr 30, 2024

CDFN commented Apr 30, 2024

CDFN commented Apr 30, 2024

achou11 commented Apr 30, 2024

achou11 left a comment

Choose a reason for hiding this comment

bohdanprog commented Apr 30, 2024 • edited Loading

ErikSin commented Apr 30, 2024

achou11 Apr 29, 2024 •

edited

Loading

ErikSin left a comment •

edited

Loading

ErikSin Apr 30, 2024 •

edited

Loading

achou11 commented Apr 30, 2024 •

edited

Loading

bohdanprog commented Apr 30, 2024 •

edited

Loading