Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to bootstrap 5.3 #19

Closed
wants to merge 77 commits into from
Closed

Upgrade to bootstrap 5.3 #19

wants to merge 77 commits into from

Conversation

skyporter
Copy link

@skyporter skyporter commented Apr 27, 2024 •
edited
Loading

  • bundle update boostrap and bootstrap_form gem
  • move some "model translations" into the right location
  • update forms according to the new BS5 form structuration (ie. form-group=> mb-3) + add missing form classes (ie. form-label)
  • update BS5 JS selectors of dropdown, modal, popover (ie. data-toggle="dropdown"=> data-bs-toggle="dropdown")
  • update to jquery3 which is a requirement of BS3
  • update to new BS5 selectors (ml-x=> ms-X, dropdown-menu-right => dropdown-menu-end, ...)
  • multiple design updates to look and feel like the current application
  • add missing hr on forms before the primary submit button

skyporter added 30 commits April 24, 2024 10:16
@skyporter
bundle update gem
424e2e1
@skyporter
move translations to the right place
d912311
@skyporter
fix help text on url field
2d7e36d
@skyporter
remove link underline decoration
07452ee
@skyporter
data-toggle="dropdown" => data-bs-toggle="dropdown"
9bd823b
@skyporter
bs5 depend of jquery3 (updated from jquery 1)
56c834e
@skyporter
Update some form CSS to looks like actual design
df632ba
@skyporter
add form-label on each label tags
93cdcec
@skyporter
Convert form-group to mb-3 or <%= f.form_group do %>
0e61662
@skyporter
Add some missing form-label
d9fdd82
@skyporter
Using css variable to change border color
72ca06b
@skyporter
bs5 popover
a9849ea
@skyporter
fix form formatting (add missing form group)
b6b618b
@skyporter
fix form formatting on "add choice set modal"
4a01f5a
@skyporter
fix openning modal with bs5
e281c2a
@skyporter
Update all BS5 class selector ml-X and mr-X to ms-X (start) and…
552caf9 
… `me-X` (end)
@skyporter
update list group padding
32cbb3c
@skyporter
update TranslatedTextField from field (remove whitespace between titl…
8d7498d 
…e and input)
@skyporter
update dropdown (dropdown-menu-right => dropdown-menu-end)
aaa0fea
@skyporter
remove duplicated card-body clas
3b73df7
@skyporter
add missing translation
e520239
@skyporter
add same margin-bottom on "translated inputs fields"
5f01a40
@skyporter
on bs5 table has border bottom => remove this border bottom on card
b51465b
@skyporter
update BS5 badge badge-XX => text-bg-XX and badge-pill => `roun…
de3c0ec 
…ded-pill`
@skyporter
pl-X => ps-X
4ebd0b2
@skyporter
update badge again
58fd364
@skyporter
overflow table-index only (keep dropdown over panel)
9ae7f5c
@skyporter
add missing "hr" on forms
7157a67
@skyporter
fix table border on panel
e4473d0
@skyporter
modal close btn and header margin
b0288e1
skyporter and others added 29 commits April 25, 2024 22:21
@skyporter
upgrade obsolete align right attribute
446fb6f
@skyporter
responsive users table
d051ba3
@skyporter
responsive navbar collapse
0a90acd
@skyporter
new text-right syntaxe
a4039ab
@skyporter
hr before primary
f698ac4
@skyporter
fix
5f24d22
@skyporter
active the right nav element
11e3727
@skyporter
active the right nav item menu
f8d077c
@skyporter
remove double hr
970e131
@skyporter
fix align
d71f2e4
@skyporter
typo fix
efc4cf1
@skyporter
fix js error when row doesn't have template (ie: complex datation fie…
08d3e8d 
…lds)
@skyporter
Merge remote-tracking branch 'refs/remotes/origin/development' into b…
f84d4b8 
…ootstrap-5.3

# Conflicts:
#	app/views/catalog_admin/users/index.html.erb
@skyporter
fix some tests
63eb067
@skyporter
fix one more test
30f6bc7
@skyporter
update referenceEditor to looks like other inputs
958b5f1
@skyporter
fix one test
91d0939
@skyporter
fix another test
3ee9752
@skyporter
fix one more test
ae82f06
@skyporter
rollback wrong commit
fdf7066
@skyporter
fix last test
02b77cc
@skyporter
design update on search form
e56f130
@skyporter
remove not used code
d8ff179
@skyporter
remove not used import
34595ad
@skyporter
update dropdown toggle on summer note editor
7ff12fa
@skyporter
wip datepicker
d0c96c4
fix refs regarding _linkRangeDatepickers
725973a
@skyporter
datepicker update for complexe datation field
6b62f0f
@skyporter
remove bootstrap4-datetimepicker references
f6626e7
@skyporter skyporter closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skyporter