-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Diesel 2.0.0-rc.0 #29
Conversation
@weiznich could you review this please? thanks 😄 |
@Emulator000 No need to ping me for that, especially not if this PR was opened less than a day before. Remember that is a free time project for me, so it could take some time till I answer to issues or other things. Especially PR reviews can take time. |
sorry, no pressure at all, just because I weren't able to assign the PR review to you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR. This looks fine beside the u32
-> i32
change for the TsConfiguration
struct. I would like to hear some justification there.
src/lib.rs
Outdated
#[sql_type = "Regconfig"] | ||
pub struct TsConfiguration(pub u32); | ||
#[diesel(sql_type = RegConfig)] | ||
pub struct TsConfiguration(pub i32); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment here why the type of the inner field was changed to i32
?
@Emulator000 Can you respond to the above? Would be great to have this merged in! |
If I remember correctly, I had a little issue with a new lifetime introduced by the changes of the new function arguments definition, anyway it should be safe to leave as is. I'll try to recall later but I think that is not a blocking issue. |
I would like to keep the old signature there to minimize breaking changes. |
@weiznich I reverted to |
In this PR i just updated the dependency crate to Diesel 2.0.0-rc.0 and changed the
TsConfiguration
accordingly to the new serializer functionToSql