-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove trailing whitespace after ASC/DESC postfix operators #4076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Other postfix operators have only a leading space, not a trailing one. And generation is tested in all_about_inserts
.
Remove trailing whitespace after ASC/DESC postfix operators
@weiznich What is the procedure concerning the release of purely syntactical changes such as here, in #4116, in #4398, and maybe other PRs? I have noticed that these changes have not been part of a previous releases, nor do they seem to be planned for an upcoming release. I am aware that these are purely non-functional fixes, but I'd love to have "clean" SQL for log messages etc. Are changes like these considered breaking and need to be postponed until the next major release Diesel 3.x? |
Remove trailing whitespace after ASC/DESC postfix operators
It's mostly that backporting fixes is effort, so I only backport fixes that I see as bug fixes solving an existing problem. I personally do not classify this change as worth being backport as I see this as purely synthetic change. That all written: The next release will likely be 2.3, not 3.0. Also this change is clearly nothing that requires a major release. |
Remove trailing whitespace after ASC/DESC postfix operators
Thank you for your reply. I have opened pull request weiznich#8 with the backports for #4076, #4116, #4398.
👍 |
The fix is in line with all other occurrences of
postfix_operator!()
, none of which include trailing whitespace (as opposed toinfix_operator!()
andprefix_operator!()
definitions).Fixes #4075