Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing whitespace after ASC/DESC postfix operators #4076

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

sgoll
Copy link
Contributor

@sgoll sgoll commented Jun 19, 2024

The fix is in line with all other occurrences of postfix_operator!(), none of which include trailing whitespace (as opposed to infix_operator!() and prefix_operator!() definitions).

Fixes #4075

Copy link

@kw217 kw217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Other postfix operators have only a leading space, not a trailing one. And generation is tested in all_about_inserts.

@weiznich weiznich added this pull request to the merge queue Jun 24, 2024
Merged via the queue into diesel-rs:master with commit e9093a2 Jun 24, 2024
49 checks passed
sgoll pushed a commit to sgoll/diesel that referenced this pull request Dec 18, 2024
Remove trailing whitespace after ASC/DESC postfix operators
@sgoll
Copy link
Contributor Author

sgoll commented Feb 15, 2025

@weiznich What is the procedure concerning the release of purely syntactical changes such as here, in #4116, in #4398, and maybe other PRs? I have noticed that these changes have not been part of a previous releases, nor do they seem to be planned for an upcoming release.

I am aware that these are purely non-functional fixes, but I'd love to have "clean" SQL for log messages etc. Are changes like these considered breaking and need to be postponed until the next major release Diesel 3.x?

sgoll pushed a commit to sgoll/diesel that referenced this pull request Feb 15, 2025
Remove trailing whitespace after ASC/DESC postfix operators
@weiznich
Copy link
Member

It's mostly that backporting fixes is effort, so I only backport fixes that I see as bug fixes solving an existing problem. I personally do not classify this change as worth being backport as I see this as purely synthetic change.
If you care about this feel free to backport it and open a PR against the branch for #4490.

That all written: The next release will likely be 2.3, not 3.0. Also this change is clearly nothing that requires a major release.

sgoll pushed a commit to sgoll/diesel that referenced this pull request Feb 15, 2025
Remove trailing whitespace after ASC/DESC postfix operators
@sgoll
Copy link
Contributor Author

sgoll commented Feb 15, 2025

If you care about this feel free to backport it and open a PR against the branch for #4490.

Thank you for your reply. I have opened pull request weiznich#8 with the backports for #4076, #4116, #4398.

That all written: The next release will likely be 2.3, not 3.0. Also this change is clearly nothing that requires a major release.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASC/DESC postfix operators include trailing whitespace
3 participants