Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance H5 I/O #2

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Enhance H5 I/O #2

wants to merge 15 commits into from

Conversation

dimitrivlachos
Copy link

@dimitrivlachos dimitrivlachos commented Jan 27, 2025

Create a generic H5 writer — along with unit tests — that can take
generic data and write it to a file. As well as adding more robust error
handling to the reader.

  • Create new subdirectory h5 in include/dx2 to logically group h5
    related code.
  • Create new header file dx2/h5/h5write.h to define the writer.
  • Move h5read_processed into dx2/h5 and add error handling.
  • Create new test file test/test_write_h5_array.cxx for validation.
  • Modify CMakeLists.txt to include the new header file, tests and
    changes to allow this to be included by other projects.

@dimitrivlachos dimitrivlachos force-pushed the h5_writer branch 4 times, most recently from 729df1d to 7244d40 Compare January 28, 2025 11:39
@dimitrivlachos dimitrivlachos changed the title Add basic H5 writer and test Enhance H5 I/O Jan 28, 2025
@dimitrivlachos dimitrivlachos self-assigned this Jan 30, 2025
@dimitrivlachos dimitrivlachos added the enhancement New feature or request label Jan 30, 2025
@dimitrivlachos dimitrivlachos marked this pull request as ready for review February 3, 2025 09:08
@dimitrivlachos dimitrivlachos force-pushed the h5_writer branch 2 times, most recently from 6d65bd2 to d79c340 Compare February 4, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants