-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance H5 I/O #2
Open
dimitrivlachos
wants to merge
15
commits into
main
Choose a base branch
from
h5_writer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
729df1d
to
7244d40
Compare
7244d40
to
da24d26
Compare
6d65bd2
to
d79c340
Compare
d79c340
to
48d723a
Compare
48d723a
to
7c675d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a generic H5 writer — along with unit tests — that can take
generic data and write it to a file. As well as adding more robust error
handling to the reader.
h5
ininclude/dx2
to logically group h5related code.
dx2/h5/h5write.h
to define the writer.h5read_processed
intodx2/h5
and add error handling.test/test_write_h5_array.cxx
for validation.CMakeLists.txt
to include the new header file, tests andchanges to allow this to be included by other projects.