Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw #37

Closed
Closed

Conversation

VanshikaSabharwal
Copy link
Contributor

This is a sub issue #35 of issue #29

I have added husky and pre-commits.

@dhruvpatidar359 you can merge husky for a consistent code workflow.

Copy link

vercel bot commented May 12, 2024

@VanshikaSabharwal is attempting to deploy a commit to the dhruvpatidar359's projects Team on Vercel.

A member of the Team first needs to authorize it.

@dhruvpatidar359 dhruvpatidar359 added gssoc Issues / PR related to Gssoc'24 level3 Issues / PR related to Gssoc'24 difficulty hard labels May 12, 2024
Copy link

vercel bot commented May 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextdraw ❌ Failed (Inspect) May 16, 2024 8:59am

fix : ESLint configuration in client.eslintrc.cjs is invalid: - Unexpected top-level property "files"
@VanshikaSabharwal
Copy link
Contributor Author

hey @dhruvpatidar359 , Can you please merge my PR.

@dhruvpatidar359
Copy link
Owner

dhruvpatidar359 commented May 14, 2024 via email

@VanshikaSabharwal
Copy link
Contributor Author

Okay . Do tell me if any help needed @dhruvpatidar359 . I'll do my best

@dhruvpatidar359
Copy link
Owner

Okay . Do tell me if any help needed @dhruvpatidar359 . I'll do my best

Have a look 👀
image

@dhruvpatidar359
Copy link
Owner

Okay . Do tell me if any help needed @dhruvpatidar359 . I'll do my best

Have a look 👀 image

This was the original error
image

@dhruvpatidar359
Copy link
Owner

the deployment works well , but i think the eslint rules are breaking in this

@VanshikaSabharwal
Copy link
Contributor Author

the deployment works well , but i think the eslint rules are breaking in this

Yes, Have you tried downloading @typescript-eslint/eslint-plugin?

updated package.json
@dhruvpatidar359
Copy link
Owner

may you please update the npm i @typescript-eslint/parser and add the package that u said . In the PR

@VanshikaSabharwal
Copy link
Contributor Author

may you please update the npm i @typescript-eslint/parser and add the package that u said . In the PR

Okay, I am doing it

@VanshikaSabharwal
Copy link
Contributor Author

I have installed @typescript-eslint/parser and @typescript-eslint/eslint-plugin. Good to go @dhruvpatidar359

@dhruvpatidar359
Copy link
Owner

image

i think still there is some issue with this .

@VanshikaSabharwal
Copy link
Contributor Author

image

i think still there is some issue with this .

Hmm, I think this issue is due to

image

i think still there is some issue with this .

Prop type is not defined that is why the build failed.

The errors are indication that eslint is working fine and wants us to resolve every error in code.

@dhruvpatidar359
Copy link
Owner

@VanshikaSabharwal right now , i have merged your commits , directly into the master . So i can't merge this PR any more . What we can do is create a new PR again represeting the same issue . But with other code change if you can , but we can't add this code anymore . I will tag that PR as gssoc and level3 .

Actully i had to do that because , Props Type issue is not coming in the master , so i just cherry picked you commits and put those in the master . So don't worry , open a new PR i will merge it directly for you . 👩‍🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Issues / PR related to Gssoc'24 level3 Issues / PR related to Gssoc'24 difficulty hard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants