-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draw #37
Draw #37
Conversation
@VanshikaSabharwal is attempting to deploy a commit to the dhruvpatidar359's projects Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fixed typo
fix : ESLint configuration in client.eslintrc.cjs is invalid: - Unexpected top-level property "files"
hey @dhruvpatidar359 , Can you please merge my PR. |
Actually there is some issue in the eslintsec.config file , which is
causing the eslint check to not work in production . I have tried to
resolve it , but failed will share that soon
…On Tue, May 14, 2024, 7:12 PM Vanshika Sabharwal ***@***.***> wrote:
hey @dhruvpatidar359 <https://github.com/dhruvpatidar359> , Can you
please merge my PR.
—
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYYPYM3CBR4YPEAOGNAWOX3ZCIIFJAVCNFSM6AAAAABHS4GTN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQGI4DAMRZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Okay . Do tell me if any help needed @dhruvpatidar359 . I'll do my best |
|
|
the deployment works well , but i think the eslint rules are breaking in this |
Yes, Have you tried downloading @typescript-eslint/eslint-plugin? |
updated package.json
may you please update the |
Okay, I am doing it |
I have installed @typescript-eslint/parser and @typescript-eslint/eslint-plugin. Good to go @dhruvpatidar359 |
@VanshikaSabharwal right now , i have merged your commits , directly into the master . So i can't merge this PR any more . What we can do is create a new PR again represeting the same issue . But with other code change if you can , but we can't add this code anymore . I will tag that PR as gssoc and level3 . Actully i had to do that because , Props Type issue is not coming in the master , so i just cherry picked you commits and put those in the master . So don't worry , open a new PR i will merge it directly for you . 👩🚀 |
This is a sub issue #35 of issue #29
I have added husky and pre-commits.
@dhruvpatidar359 you can merge husky for a consistent code workflow.