string_view -> string ref

dhconnelly · Nov 28, 2024 · 486bb9a · 486bb9a
1 parent c2c125d
commit 486bb9a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/json/parser.cc b/src/json/parser.cc
@@ -242,16 +242,14 @@ ValuePtr Parser::Value() {
     }
 }
 
-/* static */
 ValuePtr Parse(FILE* f, int size) {
     auto parser = Parser(f, size);
     auto value = parser.Value();
     if (parser.pos() != size) throw ParsingError("unexpected trailing data");
     return value;
 }
 
-/* static */
-ValuePtr Parse(const std::string_view s) {
+ValuePtr Parse(const std::string& s) {
     std::unique_ptr<FILE, decltype(&fclose)> f(
         fmemopen((void*)s.data(), s.size(), "r"), fclose);
     if (f.get() == nullptr) throw SystemError(errno);

diff --git a/src/json/parser.h b/src/json/parser.h
@@ -66,7 +66,7 @@ class Parser {
 };
 
 ValuePtr Parse(FILE* f, int size);
-ValuePtr Parse(const std::string_view s);
+ValuePtr Parse(const std::string& s);
 
 }  // namespace json
 }  // namespace gabby