Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout #457

Closed
wants to merge 6 commits into from
Closed

layout #457

wants to merge 6 commits into from

Conversation

Veda273
Copy link

@Veda273 Veda273 commented Oct 29, 2024

Pull Request Template for GSoC 2024

#440

closes:
I did the following changes:
1)added a show options/hide options toggle to maintain neat and spacious layout.
2)styled the headings using animation keyframes and altered the styling using text shadow.
3)added back to top feature

[Provide a concise description of the changes introduced by this PR, detailing what’s been added, modified, or fixed.]

Type of Pull Request

  • Bug Fix
  • New Feature
  • [X ] Performance Improvement
  • Documentation Update
  • [X ] Code Refactoring
  • Security Enhancement
  • Other (Specify): _______________

(Please check relevant boxes by entering an "X" inside them)

Screen.Recording.2024-10-29.095521.mp4

Checklist for Contributor

use'X' in [ ] to check it .

  • [X ] I have reviewed my code before submission.
  • [X ] I have read and followed the project's Contribution Guidelines.
  • [X ] I have tested the code thoroughly.
  • [X ] I have attached related issue numbers, screenshots, or videos (if applicable).
  • I have added comments to my code where necessary for clarity.
  • [ X] I have checked the existing code base and my changes do not introduce any breaking changes.
  • [X ] My PR addresses only one issue; I have created separate PRs for other issues.
  • [ X] I have ensured that the PR does not include unrelated files.
  • [X ] I am mindful of the project's coding standards and best practices.

@dhairyagothi , please review my pr.

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
station-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 0:42am
station-guide-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 0:42am

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@dhairyagothi
Copy link
Owner

yrrrr don't change UI . keep it same as figma design

@Veda273
Copy link
Author

Veda273 commented Oct 30, 2024

okay..i will change it.

@Veda273
Copy link
Author

Veda273 commented Oct 30, 2024

Screen.Recording.2024-10-31.002225.mp4

I made the following changes without changing the figma design:
1)Sticky Navbar: The navbar is now sticky, staying at the top as you scroll.
2)Subtle Hover and Shadow Effects: Improved hover effects and shadows on action buttons for better visual hierarchy.
3)animation to heading for better visual appearance.
@dhairyagothi please review my pr.

@dhairyagothi
Copy link
Owner

navbar is not good @Veda273
other then that i don't see any changes

@Veda273
Copy link
Author

Veda273 commented Oct 31, 2024

@dhairyagothi I'll make the final changes and update you by tomorrow

@Veda273
Copy link
Author

Veda273 commented Nov 1, 2024

image
@dhairyagothi is it ok now?

@dhairyagothi
Copy link
Owner

Keep it as Figma UI no background in navbar and also components of navbar are not ok . Previous one is good no changes needed

@Veda273
Copy link
Author

Veda273 commented Nov 1, 2024

so, is the issue closed?

@dhairyagothi
Copy link
Owner

you have added fade in fade out animation that is good just add that make a new PR

@Veda273
Copy link
Author

Veda273 commented Nov 2, 2024

okk..done

@Veda273
Copy link
Author

Veda273 commented Nov 2, 2024

@dhairyagothi , please review

@dhairyagothi
Copy link
Owner

@dhairyagothi , please review

I will check it till night

@Veda273
Copy link
Author

Veda273 commented Nov 6, 2024

@dhairyagothi since i did not make much changes, i request you to close this issue by assigning level 1..

@dhairyagothi
Copy link
Owner

changes will mashup repo and there are conflicts bro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants