Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language content overlapping corrected : #326 done #328

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

VinayLodhi1712
Copy link
Contributor

@VinayLodhi1712 VinayLodhi1712 commented Oct 19, 2024

Pull Request Template for GSoC 2024

#326 done
closes: #326

Description of Changes

making the google language widget to an icon onclicking that it will open modal to select the language. this will enhance frontend by it does not get overlapped by any other component on any page.

Type of Pull Request

  • Bug Fix
  • [ X] New Feature
  • Performance Improvement
  • Documentation Update
  • Code Refactoring
  • Security Enhancement
  • Other (Specify): _______________

(Please check relevant boxes by entering an "X" inside them)

Screenshots / Demo (if applicable)

20241019143208.mp4

Checklist for Contributor

use'X' in [ ] to check it .

  • [ X] I have reviewed my code before submission.
  • [X ] I have read and followed the project's Contribution Guidelines.
  • [ X] I have tested the code thoroughly.
  • [X ] I have attached related issue numbers, screenshots, or videos (if applicable).
  • [ X] I have added comments to my code where necessary for clarity.
  • [ X] I have checked the existing code base and my changes do not introduce any breaking changes.
  • [X ] My PR addresses only one issue; I have created separate PRs for other issues.
  • [ X] I have ensured that the PR does not include unrelated files.
  • [X ] I am mindful of the project's coding standards and best practices.

Additional Information

if possible make it level 2 as i have to convert it to the icon and make it go throughly in responsive mode also. And I have take task only for the booking page but i have correct it for the whole website page. Now it will look good for all pages.

Contribution Guidelines Reminder

Thank you for contributing to our project! Please ensure you follow the guidelines below:

Contribution Levels

  1. Task Categories:

    • Basic Tasks: Primarily focused on small changes like minor bug fixes, documentation improvements, and unit testing. Labeled as Easy.
    • Intermediate Tasks: Moderate-level tasks that involve enhancing existing features, code refactoring, or performance improvements. Labeled as Medium.
    • Advanced Tasks: Complex tasks like building new features, significant refactoring, or critical bug fixes. Labeled as Hard.
  2. Acknowledging Effort:

    • Exceptional contributions will be recognized with a higher contribution level if substantial effort and innovation are demonstrated.

Review Process

  • PRs will be reviewed by the maintainers, and feedback will be provided. Contributors should address feedback promptly and resubmit the PR if necessary.

  • Contributors are encouraged to participate in the review process of other PRs for community growth.

We appreciate your time and effort in improving this project and look forward to your valuable contributions!

Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
station-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 9:09am
station-guide-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 9:09am

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@dhairyagothi dhairyagothi added level 2 25 Points Issue gssoc-ext GSSOX'24 Extended hacktoberfest-accepted Hacktoberfest labels Oct 20, 2024
@dhairyagothi dhairyagothi merged commit e2fb9cd into dhairyagothi:main Oct 20, 2024
5 checks passed
@dhairyagothi
Copy link
Owner

Thanks @VinayLodhi1712

Copy link
Contributor

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to Station Guide. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext GSSOX'24 Extended hacktoberfest-accepted Hacktoberfest level 2 25 Points Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Booking page overlapped with the language selection component.
2 participants