Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added station services #228

Merged
merged 3 commits into from
Oct 13, 2024
Merged

Conversation

haseebzaki-07
Copy link
Contributor

@haseebzaki-07 haseebzaki-07 commented Oct 12, 2024

fixes #203

Description of Changes

This PR encourages the booking functionality of services at a specific station by fetching all the available services with count.
It has suggestions for stations in the database from which one can select the desired station to proceed with the booking.

It has backend routes and controllers for fetching all stations , creating a station, fetching stations bookings, fetching coolies , wheelchairs and cloakroom for a station by Id.

Also i migrated the bookings component from pages/booking.jsx to components/BookingForm.jsx and updated the routes for improving modularity of the code.

Type of Pull Request

  • Bug Fix
  • New Feature
  • Performance Improvement
  • Documentation Update
  • Code Refactoring
  • Security Enhancement
  • Other (Specify): _______________
2024-10-13.01-29-41.mp4

Screenshots / Demo (if applicable)

(https://github.com/user-attachments/assets/896372ca-424d-454e-9b59-2b2408cfa31c)

get all stations:
Screenshot 2024-10-13 013019

get all stations booking by id:
Screenshot 2024-10-13 013058

get station coolie booking:
Screenshot 2024-10-13 013238

get station wheelchair booking:
Screenshot 2024-10-13 013303

Checklist for Contributor

use'X' in [X] to check it .

  • I have reviewed my code before submission.
  • I have read and followed the project's Contribution Guidelines.
  • I have tested the code thoroughly.
  • I have attached related issue numbers, screenshots, or videos (if applicable).
  • I have added comments to my code where necessary for clarity.
  • I have checked the existing code base and my changes do not introduce any breaking changes.
  • My PR addresses only one issue; I have created separate PRs for other issues.
  • I have ensured that the PR does not include unrelated files.
  • I am mindful of the project's coding standards and best practices.

Additional Information

[Include any additional context or relevant information that may help in reviewing this PR.]

Contribution Guidelines Reminder

Thank you for contributing to our project! Please ensure you follow the guidelines below:

Contribution Levels

  1. Task Categories:

    • Basic Tasks: Primarily focused on small changes like minor bug fixes, documentation improvements, and unit testing. Labeled as Easy.
    • Intermediate Tasks: Moderate-level tasks that involve enhancing existing features, code refactoring, or performance improvements. Labeled as Medium.
    • Advanced Tasks: Complex tasks like building new features, significant refactoring, or critical bug fixes. Labeled as Hard.
  2. Acknowledging Effort:

    • Exceptional contributions will be recognized with a higher contribution level if substantial effort and innovation are demonstrated.

Review Process

  • PRs will be reviewed by the maintainers, and feedback will be provided. Contributors should address feedback promptly and resubmit the PR if necessary.

  • Contributors are encouraged to participate in the review process of other PRs for community growth.

We appreciate your time and effort in improving this project and look forward to your valuable contributions!

Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
station-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 6:00am
station-guide-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 6:00am

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@dhairyagothi
Copy link
Owner

@haseebzaki-07 good but add booking.jsx in pages folder only don't add it in component
also share video of working of backend i am unable to see in hosting

@haseebzaki-07
Copy link
Contributor Author

@dhairyagothi sure I will add the bookings back in pages and please explain me what you want to see in the backend as these are all the changes I have made.

@haseebzaki-07
Copy link
Contributor Author

haseebzaki-07 commented Oct 13, 2024

@dhairyagothi You wont be able to see the backend functioning without a database.
Also I had added the booking page back to pages.

@dhairyagothi
Copy link
Owner

@haseebzaki-07 i know that but there is problem in deployment in backend on vercel

i kust want to check how changes is working with backend

@dhairyagothi dhairyagothi added the level 3 45 points issue label Oct 13, 2024
@dhairyagothi
Copy link
Owner

great work @haseebzaki-07 kudos to you thankyou so much

@dhairyagothi dhairyagothi merged commit d9a3ee9 into dhairyagothi:main Oct 13, 2024
4 checks passed
Copy link
Contributor

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to Station Guide. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

@haseebzaki-07
Copy link
Contributor Author

@dhairyagothi it's my pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext GSSOX'24 Extended hacktoberfest-accepted Hacktoberfest level 3 45 points issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Station services
2 participants