Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stations, enhance the search bar, added loading animation at station page, added zone and address of the stations. #216

Merged
merged 5 commits into from
Oct 13, 2024

Conversation

Vaibhav-Samdani
Copy link
Contributor

Pull Request Template for GSoC 2024

Related Issue

#196

Description of Changes

  • Added the station list available in india.
  • Data coming from backend using api.
  • Improved search feature.
  • Added loading animation on station page.
  • Added dataset of the station along with their address, zone and code for further feature.
    🥇 Plesase assign level3 as the work i have done!.

Type of Pull Request

  • Bug Fix
  • New Feature
  • Performance Improvement
  • Documentation Update
  • Code Refactoring
  • Security Enhancement
  • Other (Specify): Added station list.

Screenshots / Demo

image

  • I have reviewed my code before submission.
  • I have read and followed the project's Contribution Guidelines.
  • I have tested the code thoroughly.
  • I have attached related issue numbers, screenshots, or videos (if applicable).
  • I have added comments to my code where necessary for clarity.
  • I have checked the existing code base and my changes do not introduce any breaking changes.
  • My PR addresses only one issue; I have created separate PRs for other issues.
  • I have ensured that the PR does not include unrelated files.
  • I am mindful of the project's coding standards and best practices.

Additional Information

[Include any additional context or relevant information that may help in reviewing this PR.]

Contribution Guidelines Reminder

Thank you for contributing to our project! Please ensure you follow the guidelines below:

Contribution Levels

  1. Task Categories:

    • Advanced Tasks: Complex tasks like building new features, significant refactoring, or critical bug fixes. Labeled as Hard.
  2. Acknowledging Effort:

    • Exceptional contributions will be recognized with a higher contribution level if substantial effort and innovation are demonstrated.

Review Process

  • PRs will be reviewed by the maintainers, and feedback will be provided. Contributors should address feedback promptly and resubmit the PR if necessary.

  • Contributors are encouraged to participate in the review process of other PRs for community growth.

We appreciate your time and effort in improving this project and look forward to your valuable contributions!

Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
station-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 2:26pm
station-guide-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 2:26pm

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@dhairyagothi
Copy link
Owner

@Vaibhav-Samdani please share a video of changes

@Vaibhav-Samdani
Copy link
Contributor Author

@dhairyagothi as the size of video is greater than the limit of the github, I have uploaded on drive. Here is the link :

https://drive.google.com/file/d/1YlLYsvOkeIh1SPQR9mwHLAvG6cGCl5hq/view?usp=sharing

@dhairyagothi
Copy link
Owner

@Vaibhav-Samdani access

@Vaibhav-Samdani
Copy link
Contributor Author

@dhairyagothi access granted!

@dhairyagothi
Copy link
Owner

that's really great @Vaibhav-Samdani
can you please add api files in frontend folder ??? so that it can be access in deployment

@dhairyagothi dhairyagothi added dependencies Pull requests that update a dependency file level 3 45 points issue gssoc-ext GSSOX'24 Extended hacktoberfest-accepted Hacktoberfest labels Oct 13, 2024
@Vaibhav-Samdani
Copy link
Contributor Author

Can you explain me what do you mean by api files in frontend?

@dhairyagothi
Copy link
Owner

image

@Vaibhav-Samdani see this while deploying frontend on vercel it is not showing station because data is fetch from backend and backend is unable to deploy

@dhairyagothi
Copy link
Owner

can we fix this @Vaibhav-Samdani

@Vaibhav-Samdani
Copy link
Contributor Author

@dhairyagothi added the stations to frontend so that it will run without backend. check it now!

@dhairyagothi
Copy link
Owner

thank you so much @Vaibhav-Samdani loved the preloader

@dhairyagothi dhairyagothi merged commit 50df80e into dhairyagothi:main Oct 13, 2024
3 checks passed
Copy link
Contributor

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to Station Guide. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file gssoc-ext GSSOX'24 Extended hacktoberfest-accepted Hacktoberfest level 3 45 points issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants