Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve error highlighting range for M0072 #4897

Merged
merged 3 commits into from
Feb 18, 2025
Merged

fix: improve error highlighting range for M0072 #4897

merged 3 commits into from
Feb 18, 2025
+7 −7

Conversation

rvanasa
Copy link
Contributor

@rvanasa rvanasa commented Feb 13, 2025 •
edited
Loading

Changes the field * does not exist in type error message to use the AST range of the field identifier rather than the parent expression.

Mostly relevant for the Motoko VS Code extension, Motoko Playground, and ICP Ninja.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

Comparing from 497d860 to 58e5e5d:
The produced WebAssembly code seems to be completely unchanged.

@crusso crusso self-requested a review February 14, 2025 21:40
@rvanasa rvanasa marked this pull request as ready for review February 18, 2025 17:30
@rvanasa rvanasa requested a review from a team as a code owner February 18, 2025 17:30
@rvanasa rvanasa added the automerge-squash When ready, merge (using squash) label Feb 18, 2025
@mergify mergify bot merged commit c86e80f into master Feb 18, 2025
12 checks passed
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Feb 18, 2025
@mergify mergify bot deleted the ryan/fix-M0028-line-col branch February 18, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crusso crusso crusso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvanasa @crusso