chore: use npx to run mops
#288
Open
+3,136
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanasa
reviewed
Feb 15, 2025
| "build": ["mops-cli build service/saved/Saved.mo"], | ||
| "candid": "target/Saved/Saved.did", | ||
| "wasm": "target/Saved/Saved.wasm", | ||
| "build": ["mkdir -p target/saved && $(dfx cache show)/moc $(npx mops sources) service/saved/Saved.mo -o target/saved/saved.wasm --release --idl --stable-types --public-metadata candid:service"], |
There was a problem hiding this comment.
This should be npx ic-mops rather than npx mops to reference the ic-mops npm package.
I usually also include the --no flag (npx --no ic-mops) to remove the prompt to globally install Mops if the developer hasn't yet run npm install.
| @@ -1,8 +1,7 @@ | |||
| [dependencies] | |||
| base = "0.12.1" | |||
| base = "0.13.4" | |||
There was a problem hiding this comment.
Are we able to use the latest base library version?
Suggested change
| base = "0.13.4" | |
| base = "0.14.1 |
There was a problem hiding this comment.
I had that, lamentably it is not compatible as a primitive is missing. I'll update when dfx 0.25 is out.
287eaf7#diff-f51126c5f74c75e290067ee5f31e8c8d13eb2aaba192977e167c148c1222b625R2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency of the somewhat ad-hoc
mops-clicommand (and instead building withmocdirectly), and makesmopsavailable as a dev tool fromnpm. Furthermore it bumpsbaseto a more recent one.Note:
mopshas the nasty habit of changingDFX_MOC_PATHin the GitHub environment,env GITHUB_ENV=/dev/nullmakes sure that it cannot mess with it.