fix: wasm64 #273
Merged
fix: wasm64 #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new wasm64 Actor Class test revealed that the Wasm module transformation produce invalid Wasm module:
https://github.com/dfinity/motoko-playground/actions/runs/12681874194/job/35346349295#step:11:250
The transformation is implemented in
ic-wasmcrate. Thelimit_resourcepass doesn't work correctly for wasm64.The
ic-wasmfix is drafted at: dfinity/ic-wasm#79After updating
ic-wasmto use the fix branch, the previously failing test now passes.ic-wasmv0.9.2 is released with the fix. Upgrading this dependency fixed the playground.