Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Google certs HTTP outcall and transform #2766

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Implement Google certs HTTP outcall and transform #2766

merged 7 commits into from
Jan 10, 2025

Conversation

sea-snake
Copy link
Contributor

@sea-snake sea-snake commented Jan 8, 2025 •
edited by github-actions bot
Loading

Implement Google certs HTTP outcall and transform

Changes

  • Moved identity_jose from dev dependency to a regular dependency
  • Added open id and its google module with methods to get certs and apply transforms
  • The added code is currently not used yet in, unused code warnings will be shown for now

Tests

Added unit tests for the various transform methods

🟡 Some screens were changed

@sea-snake sea-snake requested a review from LXIF January 8, 2025 16:17
lmuntaner
lmuntaner reviewed Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

How have you tried it? Did you call it in another branch?

src/internet_identity/src/openid/google.rs Outdated Show resolved Hide resolved
src/internet_identity/src/openid/google.rs Outdated Show resolved Hide resolved
src/internet_identity/src/openid/google.rs Outdated Show resolved Hide resolved
src/internet_identity/src/openid/google.rs Outdated Show resolved Hide resolved
LXIF
LXIF approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@LXIF LXIF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine :)

@lmuntaner
Copy link
Collaborator

@sea-snake did you test this HTTP outcall in another branch?

@sea-snake sea-snake closed this Jan 10, 2025
@sea-snake sea-snake reopened this Jan 10, 2025
@sea-snake
Copy link
Contributor Author

@sea-snake did you test this HTTP outcall in another branch?

I tested it by temporarily adding a update and query method that call the get_certs and transform_certs respectively.

lmuntaner
lmuntaner approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sea-snake sea-snake added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit c657db5 Jan 10, 2025
68 checks passed
@sea-snake sea-snake deleted the sea-snake/google-certs-http-outcall branch January 10, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonz-dfinity jasonz-dfinity jasonz-dfinity left review comments

@LXIF LXIF LXIF approved these changes

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sea-snake @lmuntaner @LXIF @jasonz-dfinity