Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fuzzing): Add fcntl to the sandbox monitor whitelist #4217

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

venkkatesh-sekar
Copy link
Member

Corresponding failure observed on the hourly pipeline

@github-actions github-actions bot added the chore label Mar 4, 2025
@venkkatesh-sekar venkkatesh-sekar marked this pull request as ready for review March 4, 2025 09:12
@venkkatesh-sekar venkkatesh-sekar requested a review from a team as a code owner March 4, 2025 09:12
Copy link
Contributor

@berestovskyy berestovskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@adambratschikaye
Copy link
Contributor

I assume this is due to enabling the on-disk compilation cache, where the compiled Wasm artifact is passed via a file descriptor and Wasmtime executes some fcntl call to execute it?

@venkkatesh-sekar
Copy link
Member Author

venkkatesh-sekar commented Mar 4, 2025

I assume this is due to enabling the on-disk compilation cache, where the compiled Wasm artifact is passed via a file descriptor and Wasmtime executes some fcntl call to execute it?

Most likely, but I don't see any references to fcntl in the deserialize_open_file trace. I will try to dump the metadata from the fd to confirm if that's the case.

Update: I could see multiple calls to deserialize_open_file when running the fuzzer but couldn't see any fcntl call pairs. Looks like it's coming from elsewhere and will debug outside of this PR.

@venkkatesh-sekar venkkatesh-sekar added this pull request to the merge queue Mar 4, 2025
Merged via the queue into master with commit d37c766 Mar 4, 2025
19 checks passed
@venkkatesh-sekar venkkatesh-sekar deleted the vsekar/add_fcntl branch March 4, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants