Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(IDX): standardize token usage #4074

Merged
merged 28 commits into from
Feb 25, 2025
Merged

chore(IDX): standardize token usage #4074

merged 28 commits into from
Feb 25, 2025

Conversation

cgundy
Copy link
Member

@cgundy cgundy commented Feb 24, 2025 •
edited
Loading

This PR makes two changes:

  • remove workflow permissions where a GitHub token is used (the workflow permissions are not required and only cause confusion)
  • standardize how we reference the github token -> we specify it during the checkout step so it is automatically used for the rest of the workflow. It is not required to re-specify the token using the GH_TOKEN env var in later steps

Tested all the workflows and they work, including the container image update workflow.

@github-actions github-actions bot added the chore label Feb 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

Run URL: https://github.com/dfinity/ic/actions/runs/13496122249

New container image: sha256:e4997c54f75fa505d05cb3a906e940bd27e621e4776ba8670d9fd2793d713592
New container tag: 04fa7a88ec4c6922e8d7f0446c7e6c042ca62765e3cd0064a59d26d1079eb4f8

cgundy and others added 10 commits February 24, 2025 13:12
@cgundy
it works
f735fce
Updating container image to sha256:b59ca6439d16d01a299a7b0abfde39ba8a…
bd4a4c9 
…05de63608e7851f79efc2a3cc9c095

Image tag: c8f9b73153fa2b4e7a732c9713d671c35992d7a328cc6728c453ec29b8e4e883
@cgundy
Merge branch 'master' into standardize-token-usage
b247f13
@cgundy
Merge branch 'master' into standardize-token-usage
ea3459f
@cgundy
Revert "Updating container image to sha256:b59ca6439d16d01a299a7b0abf…
5bec054 
…de39ba8a05de63608e7851f79efc2a3cc9c095"

This reverts commit bd4a4c9.
Updating container image to sha256:5a6e028ac076b39353ae748ccccfc22eed…
95b9e04 
…2034d713ecd19a1a66d42fe4b3ed65

Image tag: c8f9b73153fa2b4e7a732c9713d671c35992d7a328cc6728c453ec29b8e4e883
@cgundy
Merge branch 'master' into standardize-token-usage
10118d7
@cgundy
Revert "Updating container image to sha256:5a6e028ac076b39353ae748ccc…
754f685 
…cfc22eed2034d713ecd19a1a66d42fe4b3ed65"

This reverts commit 95b9e04.
@cgundy
Merge branch 'master' into standardize-token-usage
a685702
Updating container image to sha256:88e05f111d58b18ced1b5bbabd4042a8e9…
6a1e66c 
…bd7e9fc6f221f28843a0d6b72f4ea0

Image tag: c8f9b73153fa2b4e7a732c9713d671c35992d7a328cc6728c453ec29b8e4e883
@github-actions GitHub Actions
Copy link
Contributor

Run URL: https://github.com/dfinity/ic/actions/runs/13501447897

New container image: sha256:88e05f111d58b18ced1b5bbabd4042a8e9bd7e9fc6f221f28843a0d6b72f4ea0
New container tag: c8f9b73153fa2b4e7a732c9713d671c35992d7a328cc6728c453ec29b8e4e883

@cgundy cgundy marked this pull request as ready for review February 24, 2025 17:11
@cgundy cgundy requested a review from a team as a code owner February 24, 2025 17:11
@dfinity dfinity deleted a comment from github-actions bot Feb 24, 2025
@github-actions github-actions bot added the @idx label Feb 24, 2025
@dfinity dfinity deleted a comment from github-actions bot Feb 24, 2025
@cgundy cgundy added this pull request to the merge queue Feb 25, 2025
Merged via the queue into master with commit f942097 Feb 25, 2025
33 checks passed
@cgundy cgundy deleted the standardize-token-usage branch February 25, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marko-k0 marko-k0 marko-k0 approved these changes

Assignees
No one assigned
Labels
chore @idx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgundy @marko-k0