test(nns): Stop using NnsCanisterUpgrade nns function in integration tests #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
jasonz-dfinity
dismissed
github-actions[bot]’s stale review
No canister behavior changes
jasonz-dfinity
force-pushed
the
jason/NNS1-3491-2
branch
from
c31dbec to
e0a7057
Compare
jasonz-dfinity
force-pushed
the
jason/NNS1-3491-2
branch
2 times, most recently
from
ba8ce35 to
b65da0f
Compare
jasonz-dfinity
force-pushed
the
jason/NNS1-3491-2
branch
from
b65da0f to
2a0ab7e
Compare
max-dfinity
reviewed
Feb 11, 2025
max-dfinity
approved these changes
Feb 11, 2025
ninegua
added
the
CI_ALL_BAZEL_TARGETS
ninegua
approved these changes
Feb 12, 2025
marko-k0
pushed a commit
that referenced
this pull request
Feb 14, 2025
…tests (#3841) # Why `NnsCanisterUpgrade` NNS function is deprecated. Stop using it in tests. # What * The last param of `nns_propose_upgrade_nns_canister` is always `true`. Remove it and simplify the branching. * Switch `ic_xc_ledger_suite_orchestrator_test` to using `install_nns_canister_by_proposal` and `upgrade_nns_canister_with_args_by_proposal` Co-authored-by: Paul Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
NnsCanisterUpgradeNNS function is deprecated. Stop using it in tests.What
nns_propose_upgrade_nns_canisteris alwaystrue. Remove it and simplify the branching.ic_xc_ledger_suite_orchestrator_testto usinginstall_nns_canister_by_proposalandupgrade_nns_canister_with_args_by_proposal