feat(ICP-Ledger): FI-1442: migrate ledger blocks to stable structures #3836
+310
−291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbjorkqvist
approved these changes
Feb 27, 2025
mraszyk
reviewed
Feb 28, 2025
mraszyk
reviewed
Feb 28, 2025
mraszyk
reviewed
Feb 28, 2025
mraszyk
reviewed
Feb 28, 2025
mraszyk
reviewed
Feb 28, 2025
mraszyk
reviewed
Feb 28, 2025
maciejdfinity
commented
Mar 4, 2025
| /// Stores a chain of transactions with their metadata | ||
| #[derive(Debug, Deserialize, Serialize)] | ||
| #[serde(bound = "BD: Serialize, for<'a> BD: Deserialize<'a>")] |
There was a problem hiding this comment.
Since I don't need the custom bounds for BD anymore I removed this line completely. Before the ICRC V5 PR, this line used to be #[serde(bound = "")]: 0d96610#diff-1122f1a694a6ec31534fa34a1f861a31aeaaf0cdcc8d01406dd39a480f2e7bb1L16 @mbjorkqvist @mraszyk do you know if I need the empty bounds here?
There was a problem hiding this comment.
I wouldn't expect empty bounds to make a difference, but I don't know with certainty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version migrates blocks stored in the ledger to stable structures. This allows the ledger to store more blocks and reduces the need for archiving. The archiving is still performed but its parameters (e.g.
trigger_threshold) can be adjusted. The migration is performed using timers, see #3314 description for more details.