Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(boundary): add metrics and access control to salt_sharing canister #3762

Merged
merged 7 commits into from
Feb 5, 2025

Conversation

nikolay-komarevskiy
Copy link
Contributor

@nikolay-komarevskiy nikolay-komarevskiy commented Feb 4, 2025

Changes:

  • added metrics
  • bazelification
  • access control, only API boundary nodes can call the get_salt()
  • inspect_message for early rejections of replicated query calls
  • added polling of API boundary nodes
  • improved structure by moving implementation of /logs

How to test:

// deploy with dfx
$ dfx deploy salt_sharing -m reinstall --playground --argument \          
    '(record {   
        regenerate_now = true;
        salt_generation_strategy = variant { StartOfMonth };
        registry_polling_interval_secs = 60;
    })'

Check metrics:

https://{canister_id}.raw.icp0.io/metrics

Check logs:

https://{canister_id}.raw.icp0.io/logs

@github-actions github-actions bot added the chore label Feb 4, 2025
@nikolay-komarevskiy nikolay-komarevskiy force-pushed the komarevskiy/salt-canister-metrics branch 4 times, most recently from d17ee31 to 7968439 Compare February 4, 2025 19:40
@nikolay-komarevskiy nikolay-komarevskiy force-pushed the komarevskiy/salt-canister-metrics branch from 7968439 to 58bf60d Compare February 5, 2025 08:48
@nikolay-komarevskiy nikolay-komarevskiy changed the title chore(boundary): add metrics to salt_sharing canister chore(boundary): add metrics and access control to salt_sharing canister Feb 5, 2025
@nikolay-komarevskiy nikolay-komarevskiy marked this pull request as ready for review February 5, 2025 08:51
@nikolay-komarevskiy nikolay-komarevskiy requested a review from a team as a code owner February 5, 2025 08:51
@nikolay-komarevskiy nikolay-komarevskiy added this pull request to the merge queue Feb 5, 2025
Merged via the queue into master with commit 28c8a07 Feb 5, 2025
25 checks passed
@nikolay-komarevskiy nikolay-komarevskiy deleted the komarevskiy/salt-canister-metrics branch February 5, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants