fix(IDX): don't use interpolation in x86-darwin workflow env #3656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the environment variables as set with `env:` do not
use e.g. `${ CI_RUN_ID }`. The values are set as-is, without actual
(bash-style) interpolation.
This caused the `--remap-path-prefix` not to kick in (potentially
ruining cache hits) and caused some build failures (where one cargo
crate did re-evaluate the env var string which _did_ interpolate the
variable in the build, pointing the "build dir" to an incorrect location
(`"/var/tmp/12345/"` instead of `"/var/tmp/${CI_RUN_DIR}"`,
`${CI_RUN_DIR}` verbatime) and failing the build.
nmattia
added
the
CI_MACOS_INTEL
cgundy
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the environment variables as set with
env:do not use e.g.${ CI_RUN_ID }. The values are set as-is, without actual (bash-style) interpolation.This caused the
--remap-path-prefixnot to kick in (potentially ruining cache hits) and caused some build failures (where one cargo crate did re-evaluate the env var string which did interpolate the variable in the build, pointing the "build dir" to an incorrect location ("/var/tmp/12345/"instead of"/var/tmp/${CI_RUN_DIR}",${CI_RUN_DIR}verbatim) and failing the build.