Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make regex for special address ranges more strict #2315

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fix: Make regex for special address ranges more strict #2315

merged 2 commits into from
Oct 29, 2024

Conversation

Bownairo
Copy link
Member

@Bownairo Bownairo commented Oct 29, 2024 •
edited
Loading

Successfully filters out ::1 and fe80..., and lets ...fe80... and ...::1... through.

% cat demo
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
    inet6 fe80:a424:8eec:696f:de9a:532b:bbad:f0d7/64 scope link
       valid_lft forever preferred_lft forever
    inet6 a550:fe80:8eec:696f:de9a:532b:bbad:f0d7/64 scope global
       valid_lft forever preferred_lft forever
    inet6 a550:a424:8eec:696f:de9a:532b::1/64 scope global
       valid_lft forever preferred_lft forever

% cat demo | awk '(/inet6/) && (!/\sfe80|\s::1/) { print $2 }'
a550:fe80:8eec:696f:de9a:532b:bbad:f0d7/64
a550:a424:8eec:696f:de9a:532b::1/64

@Bownairo Bownairo requested a review from a team as a code owner October 29, 2024 15:50
@github-actions github-actions bot added the fix label Oct 29, 2024
@Bownairo Bownairo marked this pull request as draft October 29, 2024 15:57
@Bownairo Bownairo marked this pull request as ready for review October 29, 2024 18:50
@Bownairo Bownairo added this pull request to the merge queue Oct 29, 2024
Merged via the queue into master with commit dac2f36 Oct 29, 2024
33 of 34 checks passed
@Bownairo Bownairo deleted the eero/setupos-regex branch October 29, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbattat andrewbattat andrewbattat approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bownairo @andrewbattat