Skip to content

Commit

Permalink
.
Browse files Browse the repository at this point in the history
  • Loading branch information
DSharifi committed Jan 20, 2025
1 parent 4e628c0 commit e9604dd
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 6 deletions.
3 changes: 2 additions & 1 deletion packages/pocket-ic/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1686,8 +1686,9 @@ To download the binary, please visit https://github.com/dfinity/pocketic."
}
}

// TODO: This process must be killed at some point
// TODO: This spawned process must be killed at some point
// to avoid it becoming a zombie.
#[allow(clippy::clippy::zombie_processes)]
cmd.spawn()
.unwrap_or_else(|_| panic!("Failed to start PocketIC binary ({:?})", bin_path));

Expand Down
4 changes: 1 addition & 3 deletions rs/execution_environment/benches/lib/src/wat_builder.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
///
/// The new WAT builder.
//
// The new WAT builder.

/// Default number of loop iterations.
pub const DEFAULT_LOOP_ITERATIONS: usize = 1_000;
Expand Down
2 changes: 1 addition & 1 deletion rs/nns/governance/src/governance.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1057,7 +1057,7 @@ impl Proposal {
fn allowed_when_resources_are_low(&self) -> bool {
self.action
.as_ref()
.map_or(false, |a| a.allowed_when_resources_are_low())
.is_some_and(|a| a.allowed_when_resources_are_low())
}

fn omit_large_fields(self) -> Self {
Expand Down
4 changes: 4 additions & 0 deletions rs/sns/governance/canister/canister.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
// TODO: Static mutable refs will become a hard error in 2024 edition of rust.
// https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html#disallow-references-to-static-mut
#![allow(static_mut_refs)]

use async_trait::async_trait;
use ic_base_types::{CanisterId, PrincipalId};
use ic_canister_log::log;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
// TODO: Static mutable refs will become a hard error in 2024 edition of rust.
// https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html#disallow-references-to-static-mut
#![allow(static_mut_refs)]

//! This is a special-purpose canister to create a large Governance proto and
//! serialize it to stable memory in a format that is compatible with the real
//! governance canister.
Expand Down
2 changes: 1 addition & 1 deletion rs/sns/swap/src/swap.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2535,7 +2535,7 @@ impl Swap {
if request
.subaccount
.as_ref()
.map_or(false, |subaccount| subaccount.len() != 32)
.is_some_and(|subaccount| subaccount.len() != 32)
{
return NewSaleTicketResponse::err_invalid_subaccount();
}
Expand Down

0 comments on commit e9604dd

Please sign in to comment.