feat: util to convert date to timestamp in nanoseconds #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
…feat/tobigintinanoseconds
size-limit report 📦
|
peterpeterparker
added a commit
that referenced
this pull request
Feb 26, 2025
…r nanoseconds (#851) # Motivation I was hesitating between using `toBigIntNanoSeconds` within `nowInBigIntNanoSeconds` or extracting a constant to avoid code duplication. The former would require updating the test as well, therefore went for the later. Furtheremore, we also unwrap the bigint to avoid unnecessary conversion as suggested in this [comment](#850 (comment)). # Changes - Extract a local constant `NANOSECONDS_PER_MILLISECOND` for `BigInt(1e6)` - `BigInt(1e6)` becomes `1_000_000n` --------- Signed-off-by: David Dal Busco <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In dapps it's could happens that date should be converted to nanoseconds. I also plan to add a util (in another PR) that will requires it. Therefore it can be handy to add a utils for such purpose.
Changes
toBigIntNanoSeconds