Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add toE8s to TokenAmountV2 #529

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Feat: Add toE8s to TokenAmountV2 #529

merged 4 commits into from
Jan 26, 2024

Conversation

lmuntaner
Copy link
Contributor

@lmuntaner lmuntaner commented Jan 26, 2024 •
edited
Loading

Motivation

Support formatting e8s for tokens that have different decimals than 8.

Changes

  • Add method toE8s to TokenAmountV2.

Tests

  • Add tests for new method.

Todos

  • Add entry to changelog (if necessary).

@lmuntaner lmuntaner force-pushed the feat_LM_add-toE8s-TokenAmountV2 branch from b040771 to 598d26d Compare January 26, 2024 15:27
@lmuntaner lmuntaner requested a review from dskloetd January 26, 2024 15:27
@lmuntaner
Copy link
Contributor Author

@dskloetd please review

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 26, 2024 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 7.12 KB (0%)
@dfinity/cketh 1.9 KB (0%)
@dfinity/cmc 1.26 KB (0%)
@dfinity/ledger-icrc 2.93 KB (0%)
@dfinity/ledger-icp 15.95 KB (0%)
@dfinity/nns 35.62 KB (0%)
@dfinity/nns-proto 76.44 KB (0%)
@dfinity/sns 15.26 KB (0%)
@dfinity/utils 4.44 KB (+0.89% 🔺)
@dfinity/ic-management 2.2 KB (0%)

@lmuntaner lmuntaner marked this pull request as ready for review January 26, 2024 15:29
@lmuntaner lmuntaner merged commit 4fd8b82 into main Jan 26, 2024
11 checks passed
@lmuntaner lmuntaner deleted the feat_LM_add-toE8s-TokenAmountV2 branch January 26, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @dskloetd