Feat: Add "logo" param to "Token" #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmuntaner
force-pushed
the
feat_LM_add-logo-to-token-type
branch
from
756b719 to
7c97133
Compare
|
@dskloetd please review |
size-limit report 📦
|
dskloetd
reviewed
Jan 17, 2024
dskloetd
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To add arbitrary ICRC we need to rely on getting the logo from the Ledger Canister metadata. Let's store it in the
Tokenwith the rest of the metadata.Changes
logotoTokentype in utils.Tests
Still passing.
Todos