Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only subtype checking for reference type #395

Merged
merged 12 commits into from
Dec 4, 2022
Merged

only subtype checking for reference type #395

merged 12 commits into from
Dec 4, 2022

Conversation

chenyan-dfinity
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity commented Dec 2, 2022

Implement #311

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Benchmark for 8405c86

Click to view benchmark
Test Base PR %
Blob/&str 211.4±127.60µs 210.5±120.47µs -0.43%
Blob/ByteBuf 137.2±49.28µs 134.8±50.28µs -1.75%
Blob/Bytes 104.1±46.86µs 103.0±46.86µs -1.06%
Blob/String 244.2±130.06µs 244.3±130.73µs +0.04%
Collections/vec (text, nat) 64.9±0.75ms 65.2±0.89ms +0.46%
Collections/vec int 30.4±0.07ms 30.9±0.09ms +1.64%
Collections/vec int64 22.5±0.23ms 21.7±0.20ms -3.56%
Collections/vec nat8 17.9±0.05ms 17.8±0.04ms -0.56%
option list/1024 2.4±0.04ms 2.1±0.01ms -12.50%
profiles/1024 4.1±0.01ms 4.2±0.01ms +2.44%
variant list/1024 2.3±0.01ms 2.3±0.03ms 0.00%

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Benchmark for fff535b

Click to view benchmark
Test Base PR %
Blob/&str 278.3±85.16µs 276.0±84.09µs -0.83%
Blob/ByteBuf 206.8±64.65µs 205.8±62.62µs -0.48%
Blob/Bytes 129.2±37.08µs 129.0±38.02µs -0.15%
Blob/String 304.3±96.62µs 302.6±96.33µs -0.56%
Collections/vec (text, nat) 88.9±1.09ms 88.4±1.16ms -0.56%
Collections/vec int 38.2±0.18ms 38.0±0.06ms -0.52%
Collections/vec int64 27.1±0.17ms 27.1±0.19ms 0.00%
Collections/vec nat8 20.5±0.03ms 21.1±0.03ms +2.93%
option list/1024 2.8±0.01ms 2.3±0.01ms -17.86%
profiles/1024 4.9±0.01ms 4.9±0.01ms 0.00%
variant list/1024 2.8±0.01ms 2.7±0.01ms -3.57%

@github-actions
Copy link

github-actions bot commented Dec 3, 2022

Benchmark for 8e65e69

Click to view benchmark
Test Base PR %
Blob/&str 189.7±66.12µs 189.0±65.18µs -0.37%
Blob/ByteBuf 137.6±49.85µs 136.1±50.13µs -1.09%
Blob/Bytes 98.1±34.69µs 98.5±36.78µs +0.41%
Blob/String 212.1±74.71µs 205.7±75.59µs -3.02%
Collections/vec (text, nat) 63.3±0.40ms 65.3±0.74ms +3.16%
Collections/vec int 29.9±0.05ms 34.6±1.94ms +15.72%
Collections/vec int64 21.7±0.19ms 20.5±0.12ms -5.53%
Collections/vec nat8 17.2±0.06ms 17.0±0.06ms -1.16%
option list/1024 2.3±0.00ms 2.1±0.02ms -8.70%
profiles/1024 4.0±0.00ms 4.3±0.02ms +7.50%
variant list/1024 2.2±0.00ms 2.3±0.01ms +4.55%

@github-actions
Copy link

github-actions bot commented Dec 3, 2022

Benchmark for dc1b488

Click to view benchmark
Test Base PR %
Blob/&str 192.8±64.89µs 188.9±63.26µs -2.02%
Blob/ByteBuf 140.0±47.74µs 136.4±50.81µs -2.57%
Blob/Bytes 101.2±33.69µs 96.8±34.29µs -4.35%
Blob/String 216.1±72.54µs 204.3±75.12µs -5.46%
Collections/vec (text, nat) 65.2±0.69ms 66.0±1.08ms +1.23%
Collections/vec int 30.0±0.11ms 30.0±0.21ms 0.00%
Collections/vec int64 21.6±0.54ms 22.1±0.21ms +2.31%
Collections/vec nat8 17.3±0.05ms 17.4±0.05ms +0.58%
option list/1024 2.3±0.00ms 1935.5±2.21µs -15.85%
profiles/1024 4.1±0.01ms 4.1±0.01ms 0.00%
variant list/1024 2.3±0.01ms 2.3±0.00ms 0.00%

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

Benchmark for f10d655

Click to view benchmark
Test Base PR %
Blob/&str 287.9±91.70µs 287.1±96.05µs -0.28%
Blob/ByteBuf 242.6±66.99µs 238.6±70.14µs -1.65%
Blob/Bytes 167.1±52.45µs 158.6±40.89µs -5.09%
Blob/String 357.4±113.71µs 340.4±88.06µs -4.76%
Collections/vec (text, nat) 92.3±4.24ms 91.6±4.02ms -0.76%
Collections/vec int 41.6±1.90ms 44.4±1.95ms +6.73%
Collections/vec int64 28.9±1.65ms 38.0±1.84ms +31.49%
Collections/vec nat8 22.7±1.30ms 22.5±1.21ms -0.88%
option list/1024 3.2±0.19ms 2.6±0.13ms -18.75%
profiles/1024 5.5±0.30ms 5.5±0.27ms 0.00%
variant list/1024 3.1±0.17ms 3.2±0.21ms +3.23%

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

Benchmark for a0eccde

Click to view benchmark
Test Base PR %
Blob/&str 188.6±67.12µs 183.2±64.96µs -2.86%
Blob/ByteBuf 136.8±49.77µs 136.6±49.02µs -0.15%
Blob/Bytes 97.3±34.23µs 96.5±33.80µs -0.82%
Blob/String 208.9±74.28µs 204.3±75.05µs -2.20%
Collections/vec (text, nat) 66.0±0.96ms 71.2±0.85ms +7.88%
Collections/vec int 30.6±0.13ms 32.0±0.50ms +4.58%
Collections/vec int64 22.2±0.24ms 21.4±0.24ms -3.60%
Collections/vec nat8 17.1±0.06ms 17.3±0.07ms +1.17%
option list/1024 2.4±0.01ms 2.1±0.00ms -12.50%
profiles/1024 4.1±0.01ms 4.1±0.01ms 0.00%
variant list/1024 2.3±0.03ms 2.4±0.07ms +4.35%

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

Benchmark for 7073bb5

Click to view benchmark
Test Base PR %
Blob/&str 273.0±87.03µs 267.4±83.70µs -2.05%
Blob/ByteBuf 203.4±64.82µs 180.8±56.18µs -11.11%
Blob/Bytes 122.7±37.98µs 124.0±35.87µs +1.06%
Blob/String 298.7±97.40µs 295.8±94.20µs -0.97%
Collections/vec (text, nat) 88.2±1.28ms 86.2±1.47ms -2.27%
Collections/vec int 37.9±0.19ms 37.8±0.17ms -0.26%
Collections/vec int64 26.7±0.28ms 26.9±0.30ms +0.75%
Collections/vec nat8 20.4±0.13ms 20.6±0.05ms +0.98%
option list/1024 2.8±0.01ms 2.3±0.01ms -17.86%
profiles/1024 4.9±0.03ms 4.9±0.03ms 0.00%
variant list/1024 2.7±0.01ms 2.7±0.01ms 0.00%

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

Benchmark for 906755e

Click to view benchmark
Test Base PR %
Blob/&str 237.0±72.52µs 236.0±71.35µs -0.42%
Blob/ByteBuf 158.1±47.78µs 164.7±46.32µs +4.17%
Blob/Bytes 108.1±32.64µs 110.7±33.13µs +2.41%
Blob/String 232.6±71.77µs 243.6±66.42µs +4.73%
Collections/vec (text, nat) 73.2±1.11ms 72.3±1.51ms -1.23%
Collections/vec int 31.5±0.07ms 31.6±0.29ms +0.32%
Collections/vec int64 22.2±0.21ms 23.7±0.22ms +6.76%
Collections/vec nat8 17.1±0.02ms 17.1±0.03ms 0.00%
option list/1024 2.4±0.00ms 2.0±0.03ms -16.67%
profiles/1024 4.1±0.01ms 4.1±0.01ms 0.00%
variant list/1024 2.3±0.00ms 2.4±0.01ms +4.35%

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

Benchmark for e0807af

Click to view benchmark
Test Base PR %
Blob/&str 269.3±82.90µs 271.3±82.98µs +0.74%
Blob/ByteBuf 180.8±57.79µs 177.6±55.76µs -1.77%
Blob/Bytes 119.9±36.72µs 121.3±35.62µs +1.17%
Blob/String 290.9±92.32µs 291.5±91.08µs +0.21%
Collections/vec (text, nat) 84.3±2.73ms 85.3±2.20ms +1.19%
Collections/vec int 36.6±1.20ms 38.4±1.19ms +4.92%
Collections/vec int64 26.0±0.89ms 26.2±0.82ms +0.77%
Collections/vec nat8 20.0±0.43ms 19.8±0.47ms -1.00%
option list/1024 2.7±0.08ms 2.2±0.06ms -18.52%
profiles/1024 4.7±0.12ms 4.8±0.14ms +2.13%
variant list/1024 2.7±0.07ms 2.6±0.08ms -3.70%

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

Benchmark for f7079b9

Click to view benchmark
Test Base PR %
Blob/&str 287.4±83.73µs 285.2±83.44µs -0.77%
Blob/ByteBuf 248.5±70.84µs 232.2±58.44µs -6.56%
Blob/Bytes 165.1±47.22µs 162.8±44.58µs -1.39%
Blob/String 348.0±87.00µs 352.1±86.49µs +1.18%
Collections/vec (text, nat) 93.9±3.67ms 91.9±2.78ms -2.13%
Collections/vec int 41.4±1.16ms 42.4±1.19ms +2.42%
Collections/vec int64 29.8±1.49ms 30.0±1.78ms +0.67%
Collections/vec nat8 22.8±1.21ms 22.7±1.33ms -0.44%
option list/1024 3.1±0.15ms 2.6±0.13ms -16.13%
profiles/1024 5.5±0.21ms 5.7±0.32ms +3.64%
variant list/1024 3.1±0.12ms 3.1±0.08ms 0.00%

@chenyan-dfinity chenyan-dfinity changed the title only subtype checking for reference type (try n) only subtype checking for reference type Dec 4, 2022
@github-actions
Copy link

github-actions bot commented Dec 4, 2022

Benchmark for 1b2333a

Click to view benchmark
Test Base PR %
Blob/&str 208.8±119.18µs 205.0±128.28µs -1.82%
Blob/ByteBuf 137.3±49.26µs 135.0±48.86µs -1.68%
Blob/Bytes 103.1±46.87µs 102.6±46.91µs -0.48%
Blob/String 242.9±130.66µs 241.3±129.45µs -0.66%
Collections/vec (text, nat) 63.7±0.47ms 67.2±0.77ms +5.49%
Collections/vec int 30.2±0.05ms 30.9±0.17ms +2.32%
Collections/vec int64 21.7±0.30ms 21.8±0.44ms +0.46%
Collections/vec nat8 17.8±0.05ms 17.7±0.07ms -0.56%
option list/1024 2.3±0.02ms 1963.5±4.06µs -14.63%
profiles/1024 4.1±0.02ms 4.1±0.05ms 0.00%
variant list/1024 2.3±0.03ms 2.3±0.01ms 0.00%

@chenyan-dfinity chenyan-dfinity merged commit b5a23d3 into master Dec 4, 2022
@chenyan-dfinity chenyan-dfinity deleted the subtype branch December 4, 2022 22:38
@github-actions
Copy link

github-actions bot commented Dec 4, 2022

Benchmark for 59a7eba

Click to view benchmark
Test Base PR %
Blob/&str 233.4±73.73µs 233.6±72.13µs +0.09%
Blob/ByteBuf 159.1±48.88µs 154.7±47.79µs -2.77%
Blob/Bytes 105.7±32.37µs 103.9±31.35µs -1.70%
Blob/String 233.1±71.53µs 230.7±70.56µs -1.03%
Collections/vec (text, nat) 73.2±1.89ms 73.3±1.23ms +0.14%
Collections/vec int 31.5±0.09ms 31.7±0.10ms +0.63%
Collections/vec int64 22.6±0.36ms 21.5±0.43ms -4.87%
Collections/vec nat8 17.1±0.02ms 17.1±0.07ms 0.00%
option list/1024 2.4±0.01ms 2.0±0.01ms -16.67%
profiles/1024 4.1±0.00ms 4.1±0.01ms 0.00%
variant list/1024 2.3±0.01ms 2.3±0.02ms 0.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant