feat: Generic Delete confirmation Modal #528
Open
+265
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivani170
requested review from
vikramdevtron and
vivek-devtron
as code owners
RohitRaj011
previously approved these changes
Jan 23, 2025
chore: Delete components in Refactoring
RohitRaj011
reviewed
Jan 24, 2025
| ) | ||
|
|
||
| const renderDeleteModal = () => ( | ||
| <ConfirmationModal |
There was a problem hiding this comment.
return this directly instead of function
RohitRaj011
reviewed
Jan 24, 2025
| @@ -77,3 +78,41 @@ export type ConfirmationModalProps<isConfig extends boolean = false> = { | |||
| : {}) | |||
|
|
|||
| export type ConfirmationModalBodyProps = Omit<ConfirmationModalProps, 'showConfirmationModal'> | |||
|
|
|||
| export type DeleteComponentModalProps = { | |||
There was a problem hiding this comment.
suggestion: can add ts-doc
RohitRaj011
approved these changes
Jan 24, 2025
shivani170
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generic Delete confirmation Modal
Type of change
Checklist