963: replace hardcoded dependency for mvn #996
+48
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurii-yu
requested review from
jan-vcapgemini
and removed request for
hohwille
yurii-yu
added
enhancement
…:yurii-yu/IDEasy into feature/963_replace_hardcoded_dependency
cli/src/test/java/com/devonfw/tools/ide/commandlet/BuildCommandletTest.java
Outdated
Show resolved
Hide resolved
cli/src/test/resources/ide-projects/build/_ide/urls/mvn/mvn/dependencies.json
Show resolved
Hide resolved
cli/src/test/resources/ide-projects/mvn/_ide/urls/mvn/mvn/dependencies.json
Show resolved
Hide resolved
cli/src/test/resources/ide-projects/update/_ide/urls/mvn/mvn/dependencies.json
Show resolved
Hide resolved
jan-vcapgemini
requested changes
Jan 30, 2025
There was a problem hiding this comment.
@yurii-yu thanks for implementing the dependencies.json for Maven. I've added some CRs please check.
hohwille
changed the title
hohwille
reviewed
Jan 30, 2025
…ependencies.json Co-authored-by: jan-vcapgemini <[email protected]>
…ndencies.json Co-authored-by: jan-vcapgemini <[email protected]>
…pendencies.json Co-authored-by: jan-vcapgemini <[email protected]>
…pendency' into feature/963_replace_hardcoded_dependency
… the unit tests we use maven 3.9.6
Pull Request Test Coverage Report for Build 13081302052Details
💛 - Coveralls |
I tried with your changes but unfortunately it does not work, because the actual version of maven we are using is 3.9.6. If we remove the configuration part of maven 3.0 to 4.0 from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #963
replace hardcoded dependency with pre-configured
dependencies.jsondependencies.jsonin ide_urls (in another repository)dependencies.jsonare correctly loaded and parsed