Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#969: Fix sleep command not found in log-order.sh #976

Merged
merged 19 commits into from
Feb 13, 2025
Merged

#969: Fix sleep command not found in log-order.sh #976

merged 19 commits into from
Feb 13, 2025
+2 −2

Conversation

alfeilex
Copy link
Member

@alfeilex alfeilex commented Jan 21, 2025 •
edited
Loading

Fixes: #969

This PR fixes the not found sleep command in GitHub Runner by adding /usr/bin entry into the PATH

@coveralls
Copy link
Collaborator

coveralls commented Jan 21, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13266506479

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.469%
Totals Coverage Status
Change from base Build 13206540769: 0.0%
Covered Lines: 7393
Relevant Lines: 10384
💛 - Coveralls

@alfeilex alfeilex self-assigned this Jan 21, 2025
@alfeilex alfeilex marked this pull request as ready for review January 21, 2025 16:53
@hohwille
Copy link
Member

This sounds like worth a try: n8n-io/n8n#309

@alfeilex alfeilex changed the title #969: Replace sleep command in log-order.sh #969: Fix sleep command not found in log-order.sh Jan 29, 2025
hohwille
hohwille approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex thanks for the pragmatic solution. 👍

We could also try not to override PATH at all but I do not know if then the test will fail for other reasons.
I will merge it now. We can still improve with another PR if we find a cleaner solution.

@hohwille hohwille added this to the release:2025.02.001 milestone Feb 13, 2025
@hohwille hohwille added internal Nothing to be added to CHANGELOG, only internal story enhancement New feature or request test related to testing and QA labels Feb 13, 2025
@hohwille hohwille merged commit 52609da into devonfw:main Feb 13, 2025
4 checks passed
@hohwille hohwille mentioned this pull request Feb 17, 2025
Closed
@jan-vcapgemini jan-vcapgemini added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Feb 25, 2025
@alfeilex alfeilex deleted the #969-fix-sleep-command-build branch February 26, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille

Assignees

@alfeilex alfeilex

Labels
enhancement New feature or request internal Nothing to be added to CHANGELOG, only internal story reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. test related to testing and QA
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2025.02.001
Development

Successfully merging this pull request may close these issues.

Sleep command isn't found in Github Runner
4 participants
@alfeilex @coveralls @hohwille @jan-vcapgemini