Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#25: implement tool commandlet for intellij #447

Merged
merged 69 commits into from
Jul 5, 2024
Merged

#25: implement tool commandlet for intellij #447

merged 69 commits into from
Jul 5, 2024

Conversation

hohwille
Copy link
Member

@hohwille hohwille commented Jul 5, 2024

implements #25
replacement for PR #297

ndemirca and others added 30 commits February 23, 2024 16:06
@ndemirca
devonfw#25: implemented install and plugins
13a2b75
@ndemirca
Merge branch 'main' into feature/25-Implement-ToolCommandlet-for-Inte…
b8292b6 
…llij
@ndemirca
added first windows unittests for intellij
bcf0e4b
@ndemirca
tested intellij installation
1194c04
@ndemirca
adapted test data for intellij commandlet
2213057
@ndemirca
Adapted intellij tests
4329115
@ndemirca
Merge branch 'main' into feature/25-Implement-ToolCommandlet-for-Inte…
b1f7e9c 
…llij
@ndemirca
adjusted test data
a1ae18a
@ndemirca
changed test data for mac
3402cc7
@ndemirca
fixed intellij Unittests
2d39454
@ndemirca
expanden intellij tool commandlet
0bd0b42
@ndemirca
added javadoc
1599acb
@ndemirca
Merge branch 'main' into feature/25-Implement-ToolCommandlet-for-Inte…
2dbd602 
…llij
@ndemirca
added improvements to intellij and optimized tests
c4ae3cf
@ndemirca
cleaned up test data
e26ce93
@ndemirca
imroved tests
7b63574
@ndemirca
fixed mac implementation
93265c9
@ndemirca
added file mode to extractDmg to fix a bug
dd5b979
@ndemirca
improved mac implementation
ab2bedd
@ndemirca
refactoring
5f5b2a9
@ndemirca
adapted tests
a87dde9
@ndemirca
fixed unittests for mac
ca10f69
@ndemirca
fixed unittest
6e46659
@ndemirca
Merge branch 'main' into feature/25-Implement-ToolCommandlet-for-Inte…
053faed 
…llij
@ndemirca
small improvements
35012f0
@ndemirca
moved open into bin folder
b9af487
@ndemirca
Merge branch 'main' into feature/25-Implement-ToolCommandlet-for-Inte…
13c526f 
…llij
@ndemirca @hohwille
fix git merge conflict leftover
c9af2b5 
Co-authored-by: Jörg Hohwiller <[email protected]>
@ndemirca
Merge branch 'feature/25-Implement-ToolCommandlet-for-Intellij' of ht…
7733bfc 
…tps://github.com/ndemirca/IDEasy into feature/25-Implement-ToolCommandlet-for-Intellij
@ndemirca
fixed gitattributes
4bbb95b
ndemirca and others added 15 commits May 28, 2024 10:50
@ndemirca
reverted refactoring
ad6f549
@ndemirca
fixed mac tests
63793c8
@hohwille
Merge branch 'main' into feature/25-Implement-ToolCommandlet-for-Inte…
9ca87e3 
…llij
@jan-vcapgemini
Merge branch 'main' into feature/25-Implement-ToolCommandlet-for-Inte…
920ccfa 
…llij

# Conflicts:
#	cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java
#	cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java
@jan-vcapgemini
Merge branch 'feature/25-Implement-ToolCommandlet-for-Intellij' of gi…
2714aa4 
…thub.com:ndemirca/IDEasy into feature/25-Implement-ToolCommandlet-for-Intellij
@jan-vcapgemini
devonfw#25: implemented requested changes
b59af50 
added new makeExecutable method to FileAccess
added new RWX_RX_RX constant to FileAccess
replaced complicated sert of execute permissions in Intellij with makeExecutable method
added TODO for the implementation of plugin installation
applid reformat to FileAccess
@jan-vcapgemini
Merge branch 'main' into feature/25-Implement-ToolCommandlet-for-Inte…
2947503 
…llij
@jan-vcapgemini
devonfw#25: fixed copy method
d9c8268
@jan-vcapgemini
devonfw#25: added mac edition handling
bd487c6
@jan-vcapgemini @hohwille
devonfw#25: implemented requested change
5c956eb 
updated .gitattributes studio64.exe

Co-authored-by: Jörg Hohwiller <[email protected]>
@jan-vcapgemini
Merge branch 'main' into feature/25-Implement-ToolCommandlet-for-Inte…
3b1fc60 
…llij
@jan-vcapgemini
Merge branch 'main' into feature/25-Implement-ToolCommandlet-for-Inte…
a549382 
…llij
@jan-vcapgemini
Merge branch 'main' into feature/25-Implement-ToolCommandlet-for-Inte…
21be926 
…llij
@hohwille
fix fileaccess to prevent IOException on findFiles
5f13d97
@hohwille
devonfw#25: fix to make MacOS workaround working somehow
b8fc3f1
@hohwille hohwille requested a review from jan-vcapgemini July 5, 2024 12:25
@hohwille hohwille added this to the release:2024.07.001 milestone Jul 5, 2024
@hohwille hohwille added intellij IntelliJ IDE from Jet-Brains enhancement New feature or request labels Jul 5, 2024
@hohwille
Copy link
Member Author

hohwille commented Jul 5, 2024

We still have tons of bugs on MacOS.
However, this way it is working (without security limitations of new MacOS) and was also tested successfully by @jan-vcapgemini
We will merge this now and then create bug issues for future improvements.

@hohwille hohwille mentioned this pull request Jul 5, 2024
Closed
@coveralls
Copy link
Collaborator

coveralls commented Jul 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9808447273

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 50 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.6%) to 61.798%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/docker/Docker.java 2 4.88%
com/devonfw/tools/ide/common/SystemPath.java 3 82.99%
com/devonfw/tools/ide/tool/tomcat/Tomcat.java 3 78.0%
com/devonfw/tools/ide/io/FileAccess.java 6 45.45%
com/devonfw/tools/ide/tool/intellij/Intellij.java 6 80.0%
com/devonfw/tools/ide/tool/sonar/Sonar.java 8 9.26%
com/devonfw/tools/ide/io/FileAccessImpl.java 22 55.37%
Totals Coverage Status
Change from base Build 9806887186: 0.6%
Covered Lines: 5264
Relevant Lines: 8196
💛 - Coveralls

@hohwille hohwille merged commit 623ef90 into devonfw:main Jul 5, 2024
4 checks passed
@hohwille hohwille linked an issue Jul 5, 2024 that may be closed by this pull request
Implement ToolCommandlet for Intellij #25
Closed
@coveralls
Copy link
Collaborator

coveralls commented Jul 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9808460741

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 50 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.6%) to 61.798%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/docker/Docker.java 2 4.88%
com/devonfw/tools/ide/common/SystemPath.java 3 82.99%
com/devonfw/tools/ide/tool/tomcat/Tomcat.java 3 78.0%
com/devonfw/tools/ide/io/FileAccess.java 6 45.45%
com/devonfw/tools/ide/tool/intellij/Intellij.java 6 80.0%
com/devonfw/tools/ide/tool/sonar/Sonar.java 8 9.26%
com/devonfw/tools/ide/io/FileAccessImpl.java 22 55.37%
Totals Coverage Status
Change from base Build 9806887186: 0.6%
Covered Lines: 5264
Relevant Lines: 8196
💛 - Coveralls

@jan-vcapgemini jan-vcapgemini added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-vcapgemini jan-vcapgemini Awaiting requested review from jan-vcapgemini

Assignees

@hohwille hohwille

@jan-vcapgemini jan-vcapgemini

Labels
enhancement New feature or request intellij IntelliJ IDE from Jet-Brains reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.07.002
Development

Successfully merging this pull request may close these issues.

Implement ToolCommandlet for Intellij
4 participants
@hohwille @coveralls @jan-vcapgemini @ndemirca