You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements NpmBasedUrlUpdater as an extension of JsonUrlUpdater
NpmUrlUpdater is now a NpmBasedUrlUpdater instead of a WebsiteUrlUpdater
Added Tests for NpmUrlUpdater
There is a rather unclean workaround to fix versions being filtered properly for npm, so that alpha/beta versions are not being made available. These versions were not available with the prior used WebsiteURLUpdater. This problematic behaviour however is not specific to npm: Currently, e.g. python too makes alpha, beta and rc versions available to the user.
This problem arises due to these tools implementing their own update method, in which doAddVersion instead of addVersion of the AbstractUrlUpdater is being utilized, and by that, circumventing the mapVersion call in which these versions would have been filtered.
I am open to suggestions for a prettier solution for this workaround, however it seems to me it requires some refactoring on AbstractUrlUpdater, and might be best to do this in a seperate issue, and consider the refactoring of NpmUrlUpdater completed.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Needs another refactoring round, moving away from overriding update, but instead implement addVersion and collectVersionsFromJson. This will also be necessary for the UrlUpdaters of AndroidStudio and Python, for which a separate Issue #458 has been opened.
Since NpmUrlUpdater needs to be reimplemented differently from the approach taken in this PR I will close this PR and open a new PR once NpmUrlUpdater is the approach discussed above.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #437.
NpmBasedUrlUpdater
as an extension ofJsonUrlUpdater
NpmUrlUpdater
is now aNpmBasedUrlUpdater
instead of aWebsiteUrlUpdater
NpmUrlUpdater
There is a rather unclean workaround to fix versions being filtered properly for npm, so that alpha/beta versions are not being made available. These versions were not available with the prior used
WebsiteURLUpdater
. This problematic behaviour however is not specific to npm: Currently, e.g. python too makes alpha, beta and rc versions available to the user.This problem arises due to these tools implementing their own
update
method, in whichdoAddVersion
instead ofaddVersion
of theAbstractUrlUpdater
is being utilized, and by that, circumventing themapVersion
call in which these versions would have been filtered.I am open to suggestions for a prettier solution for this workaround, however it seems to me it requires some refactoring on
AbstractUrlUpdater
, and might be best to do this in a seperate issue, and consider the refactoring of NpmUrlUpdater completed.