Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#337 add mac architectures #376

Conversation

jan-vcapgemini
Copy link
Contributor

Fixes: #337

Implements:

  • os-maven-plugin
  • automatic detection of OS and architectures

added architectures to OSs (default x64)
added mac-arm architecture
added automatic detection of os and architecture
@coveralls
Copy link
Collaborator

coveralls commented Jun 4, 2024

Pull Request Test Coverage Report for Build 9840802466

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.755%

Totals Coverage Status
Change from base Build 9813808982: 0.0%
Covered Lines: 5276
Relevant Lines: 8226

💛 - Coveralls

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jan-vcapgemini thanks for this PR. If I understood this approach correctly, there are issues that Java/Maven reports the architecture not properly normalized (for system property os.arch) so the same thing can get different values depending on the platform.
Therefore insted of profiles triggered by OS activation setting things like this:

       <os.detected.classifier>windows</os.detected.classifier>
       <os.detected.arch>x64</os.detected.arch>

You now use os-maven-plugin to generate such properties in a normalized way. While this seems like a smart and valid approach, you need to be aware that the previous properties where somehow made up by some developer in our team. Even though os-maven-plugin uses the same property names, it does use them not with the same semantics.
IMHO you need to change at least

<releaseName>${project.artifactId}-${os.detected.classifier}-${os.detected.arch}</releaseName>

to

<releaseName>${project.artifactId}-${os.detected.classifier}</releaseName>

or to

<releaseName>${project.artifactId}-${os.detected.name}-${os.detected.arch}</releaseName>

if I read the documentation of that plugin correctly.

Further, we have standardized our architectures differently and use x64 instead of x86_64 so we still might need to find a way how to remap these but this is some nice to have that can also be addressed after merging this PR.

@jan-vcapgemini
Copy link
Contributor Author

Can be closed because #471 was already merged.

@jan-vcapgemini jan-vcapgemini deleted the fix/337-add-mac-architectures branch November 4, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

IDEasy Mac intel architecture support for native image builds
3 participants