Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that images cause problems with setup scripts #344

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GuentherJulian
Copy link
Contributor

@GuentherJulian GuentherJulian changed the title that images cause problems with setup scripts Fix the issue that images cause problems with setup scripts Mar 7, 2022
@GuentherJulian GuentherJulian self-assigned this Mar 7, 2022
runners/katacoda/katacodaAssetManager.ts Outdated Show resolved Hide resolved
@GuentherJulian GuentherJulian requested a review from maybeec March 8, 2022 11:13
@maybeec
Copy link
Member

maybeec commented Mar 8, 2022

@GuentherJulian do you know what's up with the build?

@GuentherJulian
Copy link
Contributor Author

@GuentherJulian do you know what's up with the build?

@maybeec The OpenApi tutorials fail on the windows build because the Java version does not match. Windows Server 2022 has Java 8 as default version in GitHub, but Java 11 is required for this project. The Ubuntu environment already uses Java 11.
In this tutorials we do not use the devonfw-ide, so that the version of the OS is used. Created an issue for this, to use devonfw-ide instead devonfw-tutorials/tutorials#208

@maybeec
Copy link
Member

maybeec commented Mar 8, 2022

couldn't we then simply fix it with https://github.com/actions/setup-java ?

@GuentherJulian
Copy link
Contributor Author

couldn't we then simply fix it with https://github.com/actions/setup-java ?

That would also be a solution. My thought was that the tutorials ensure to have the correct version on their own. Independent of the environment. Maybe in the future we will have different tutorials that need different Java versions. Then we might have the same problem later.

@maybeec
Copy link
Member

maybeec commented Mar 9, 2022

OK got it. So normally the tutorial should state which devonfw ide is setup but there is no choice to impact the Java version, isn't it? I feel even Java 11 is already defaulted in the devonfw ide.
Is this tutorial not running an devonfw ide or is it an old version which is restored here or something else?
I am trying to unterstand how we get control on it. Currently I thought we already have control by the chosen devonfw ide configuration

@GuentherJulian
Copy link
Contributor Author

OK got it. So normally the tutorial should state which devonfw ide is setup but there is no choice to impact the Java version, isn't it? I feel even Java 11 is already defaulted in the devonfw ide. Is this tutorial not running an devonfw ide or is it an old version which is restored here or something else? I am trying to unterstand how we get control on it. Currently I thought we already have control by the chosen devonfw ide configuration

Yes, Java 11 is currently the default in the devonfw-ide. We simply do not install and use the devonfw-ide in these tutorials. So in the Windows workflow, the Java version of the OS is used, which is Java 8.
At the moment we only have control on the version of the ide, but not (for example) the Java version that is installed within the ide. That could be a feature for the future. But in this case, simply installing the default devonfw-ide would fix the problem, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants