api: Relax custom coefficient spacing enforcement #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloubout
force-pushed
the
custom-coeff-spacing2
branch
from
2b9c9da to
9d5d507
Compare
devito/finite_differences/tools.py
Outdated
| @@ -339,5 +339,8 @@ def process_weights(weights, expr, dim): | |||
| return shape[weights.dimensions.index(wdim)], wdim, False | |||
| else: | |||
| # Adimensional weight from custom coeffs need to be multiplied by h^order | |||
| scale = not all(sympify(w).has(dim.spacing) for w in weights if w != 0) | |||
| if all(sympify(w).is_Number for w in weights): | |||
mloubout
force-pushed
the
custom-coeff-spacing2
branch
from
9d5d507 to
afdde39
Compare
FabioLuporini
approved these changes
Feb 6, 2025
|
GTG |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2530 +/- ##
=======================================
Coverage 87.30% 87.30%
=======================================
Files 238 238
Lines 45972 45990 +18
Branches 4074 4075 +1
=======================================
+ Hits 40134 40152 +18
Misses 5150 5150
Partials 688 688 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.