Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: post mode identifier #601

Merged
merged 20 commits into from
Sep 28, 2024
Merged

fix: post mode identifier #601

merged 20 commits into from
Sep 28, 2024

Conversation

gustavogularte
Copy link
Contributor

@gustavogularte gustavogularte commented Aug 22, 2024

Closes #543

Feature

implementado a funcionalidade e o layout do componente que permite selecionar o modo/tipo de post que desejam publicar em determinada rede.

Visual evidences 🖼️

image

Checklist
  • Issue linked
  • Build working correctly
  • Tests created

Copy link
Contributor

@DominMFD DominMFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

só tem um probleminha, o post mode que será postado continua marcado para todas as contas. Por exemplo, se vc marcar o reels em uma conta, ele vai ser marcado em todas as contas ativas.

task.arend.mp4

Copy link
Contributor

@JpBurgarelli JpBurgarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bala demais!
Da um espaçamento para a área de texto so.

image

Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mano seu CSS ta MUITO bom, de verdade, simples e funcional, tudo que precisava ser!!

Sobre layouting uma alteraçào que eu sei que é diferente do figma. Coloca a borda do checkbox com roxinho tbm!
image

Preciso só que adicione o componente no ladle e tambem faça os testes do componente!

Um ultimo pedido, seu componente precisa continuar funcionando quando entramos em situaçòes de responsividade

Isso pode ser resolvido com scroll lateral e fade no seu componente igual a @juliaam fez no componente de tabber.
image

src/components/Tabber/PostModes/PostModes.tsx Outdated Show resolved Hide resolved
src/components/Tabber/PostModes/PostModes.tsx Outdated Show resolved Hide resolved
src/components/Tabber/PostModes/PostModes.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@JpBurgarelli JpBurgarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

att a branch ae, meu mano Arend!

@Luiginicoletti Luiginicoletti added the Changes Requested To simplify a changes request view label Sep 12, 2024
Copy link
Contributor

@juliaam juliaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consegue ajustar isso que se vc adicionar varios postmodes ele expande o container principal? seria interessante q tivesse so o teu scroll mesmo e ele nao se expandisse
image

src/components/Tabber/PostModes/PostModes.spec.tsx Outdated Show resolved Hide resolved
src/components/Tabber/PostModes/PostModes.tsx Outdated Show resolved Hide resolved
@juliaam juliaam removed the Changes Requested To simplify a changes request view label Sep 27, 2024
Copy link
Contributor

@juliaam juliaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ficou muito bom, o resultado com o scroll ficou mt interessante, só o design que está diferente do figma, é só esse ajuste

image

figma:

image

@juliaam juliaam merged commit d8de648 into devhatt:master Sep 28, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Componente Post Mode Identifier
7 participants