Issue 546 - Adicionar ícone de erro no accordion #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalmeida00
approved these changes
Aug 12, 2024
|
Só queboru uns testes @jorge933
|
DominMFD
approved these changes
Aug 13, 2024
juliaam
requested changes
Aug 13, 2024
src/pages/home/components/Sidebar/components/SocialAccordion/SocialAccordion.tsx
Outdated
Show resolved
Hide resolved
…ere are invalid accounts
juliaam
requested changes
Aug 13, 2024
There was a problem hiding this comment.
Então, tá com um erro no layout de como deve ficar no fim. Está sendo exibido o número de contas mesmo quando há erro um erro nas contas, isso não está de acordo com o layout. Deve haver o número de contas, ou o erro de que há alguma conta inválida:
Layout
Seu PR:
…u have invalid accounts
|
acho que seria legal colocar todos os valores do valid com true na useSocialMediaStore, pra quando chegar na master não ficar tudo vermelho @jorge933
|
Alecell
suggested changes
Aug 15, 2024
src/pages/home/components/Sidebar/components/SocialAccordion/SocialAccordion.tsx
Outdated
Show resolved
Hide resolved
src/pages/home/components/Sidebar/components/SocialAccordion/SocialAccordion.type.ts
Show resolved
Hide resolved
aalmeida00
reviewed
Aug 16, 2024
src/pages/home/components/Sidebar/components/SocialAccordion/SocialAccordion.tsx
Outdated
Show resolved
Hide resolved
aalmeida00
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #546
Feature
A tarefa consiste em exibir um ícone de erro de acordo com o campo
valide indicar qual conta está com erro.Visual evidences 🖼️
Checklist