Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character limit no MainComposer do Tabber #570

Merged
merged 7 commits into from
Jul 16, 2024
Merged

Character limit no MainComposer do Tabber #570

merged 7 commits into from
Jul 16, 2024

Conversation

zoldyzdk
Copy link
Member

Closes #557

Feature

Character limit exibindo o limite de cada postmode de cada rede social separadamente ao invés do total como é feito no MainComposer.

Visual evidences 🖼️
CharacterLimit.webm
Checklist
  • Issue linked
  • Build working correctly
  • Tests created
Additional info N/A

@zoldyzdk zoldyzdk self-assigned this Jun 29, 2024
Copy link
Contributor

github-actions bot commented Jun 29, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 65.6% 349 / 532
🔵 Statements 65.69% 383 / 583
🔵 Functions 67.42% 149 / 221
🔵 Branches 52% 143 / 275
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/MainComposer/components/ComposerEditor/ComposerEditor.tsx 68.18% 52% 50% 67.44% 38-42, 53-54, 61-67, 63-64, 64-65, 69, 76, 83-87, 84-86, 97-98
src/components/MainComposer/components/MainComposerBase/MainComposerBase.tsx 50% 100% 33.33% 50% 14, 18
src/components/Tabber/Tabber.tsx 0% 0% 0% 0% 19-20, 20, 25-28, 27, 29, 33-35, 37-38, 40, 42-69, 43-68, 44-47, 49-62, 50-52, 54-61, 55-60, 56-58, 57, 59, 64, 66-67, 71-80, 72, 72-75, 75-78, 78, 82, 84-85, 88-100, 89, 89-94, 93, 96-99, 102-104, 103, 106-119, 107, 107-109, 111-113, 112, 115-118, 121-123
Generated in workflow #1392

Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Só está faltando uma coisa, no limite de caracteres que aparece no tabber não deve aparecer os limites das outras redes na esquerda
image

Copy link
Contributor

@juliaam juliaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Precisa atualizar a branch, e não está com o comportamento esperado, atente-se aos detalhes da implementação da task, qlqr coisa chama eu no disc

image

@Alecell Alecell merged commit da0309f into master Jul 16, 2024
4 checks passed
@Alecell Alecell deleted the issue-557 branch July 16, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Character limit no MainComposer do Tabber
4 participants