Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 471 - New Account #526

Merged
merged 46 commits into from
Aug 15, 2024
Merged

Issue 471 - New Account #526

merged 46 commits into from
Aug 15, 2024

Conversation

muritadb
Copy link
Contributor

@muritadb muritadb commented Jun 8, 2024

Closes #471

Feature

Adicionado modal para seleção de Rede Social

image

Bugfix
  • Description
    N/A

  • Cause
    N/A

  • Solution
    N/A

Changelog N/A
Checklist
  • Issue linked
  • Build working correctly
  • Tests created
  • add social media into Sidebar List
  • adjust layout
Additional info Ainda precisa de ajustes

Copy link
Member

@PiluVitu PiluVitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sr Murita, foi identificado um problema grave com sua branch onde ela puxa commits que foram margeados outrora, resolva esses problemas para que possamos efetuar a revisão correta

@aalmeida00 aalmeida00 changed the base branch from issue-471 to master June 14, 2024 02:56
@aalmeida00 aalmeida00 requested a review from PiluVitu June 14, 2024 02:56
@aalmeida00
Copy link
Member

@muritadb @PiluVitu

Sr Murita, foi identificado um problema grave com sua branch onde ela puxa commits que foram margeados outrora, resolva esses problemas para que possamos efetuar a revisão correta

Foi resolvido apontando o pull request para a Master ao invés para a branch de upstream da issue dele.

image

@muritadb só é necessário fazer um rebase.

@zoldyzdk zoldyzdk linked an issue Jun 14, 2024 that may be closed by this pull request
Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Só algumas coisinhas e tambem resolver o problema no pipe, parece que um dos testes falhou

@PiluVitu PiluVitu requested review from a team, Luiginicoletti, JpBurgarelli, juliaam, Frompaje, DominMFD and PiluVitu and removed request for a team August 7, 2024 17:06
@juliaam juliaam requested review from aalmeida00 and Alecell August 9, 2024 17:08
@muritadb muritadb requested a review from juliaam August 14, 2024 15:53
@juliaam juliaam merged commit 65e6fd4 into devhatt:master Aug 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

New Account
7 participants