Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BreakPoint #250

Merged
merged 18 commits into from
Dec 12, 2023
Merged

Add BreakPoint #250

merged 18 commits into from
Dec 12, 2023

Conversation

JpBurgarelli
Copy link
Contributor

@JpBurgarelli JpBurgarelli commented Dec 5, 2023

Feature

Breakpoints/media queries Foram Criado. Abaixo O conteúdo MainContent foi usado como um exemplo.

Visual evidences 🖼️
video.mp4
Checklist
  • Issue linked
  • Build working correctly
  • Tests created
Additional info

Uma nova task foi criado para resolver o problema com o grid que, conforme a visualização da viewport diminui, o "Header" permanece fixo e não diminui conforme esperado.

Referência utilizada: https://dev.to/rembertdesigns/how-to-write-media-queries-with-sass-mixins-32e

Alecell
Alecell previously approved these changes Dec 6, 2023
src/styles/global.scss Outdated Show resolved Hide resolved
@JpBurgarelli JpBurgarelli self-assigned this Dec 6, 2023
src/styles/global.scss Outdated Show resolved Hide resolved
src/pages/home/components/Header/Header.module.scss Outdated Show resolved Hide resolved
src/components/SavBar/SavBar.module.scss Outdated Show resolved Hide resolved
aalmeida00
aalmeida00 previously approved these changes Dec 11, 2023
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Show resolved Hide resolved
src/styles/breakpoints.scss Outdated Show resolved Hide resolved
Copy link
Member

@Luiginicoletti Luiginicoletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fiz alguns comentários jp, bom pr. abracao.

src/components/MainComposer/MainComposer.module.scss Outdated Show resolved Hide resolved
src/components/MainComposer/MainComposer.module.scss Outdated Show resolved Hide resolved
aalmeida00
aalmeida00 previously approved these changes Dec 12, 2023
@Alecell Alecell merged commit 32c6b7e into master Dec 12, 2023
1 of 2 checks passed
@Alecell Alecell deleted the BreakPoints/#234 branch December 12, 2023 18:55
PiluVitu pushed a commit that referenced this pull request Jan 1, 2024
* Add BreakPoint

* Change pixel for rem, add variables and adjust breakpoint  size

* Add new Breakpoints and Remove unnecessary things

* Add min-widht instead max-width

* chore: install pnpm

* fix: change pack ecosystem name

* fix: change pack ecosystem name second

* chore: change package manager in files

* style: add eof

* fix: change the package ecosystem name 2

* style: add eof

* fix: change the breakpoints and sizes

* fix: update Branch

* fix: erase the comment

* style: add eof again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants