Adiciona botão de adicionar nova conta #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalmeida00
previously approved these changes
Nov 27, 2023
Alecell
suggested changes
Nov 29, 2023
aalmeida00
previously approved these changes
Dec 1, 2023
aalmeida00
previously approved these changes
Dec 5, 2023
Alecell
suggested changes
Dec 6, 2023
There was a problem hiding this comment.
Sobre as condicionar que vc moveu para as funções, é importante ressaltar que o problema é a condicional multiline, se for uma condicional que cabe e fica legivel em 1 linha só, isso ta tudo bem!
Por isso fiz essas observações agora, mas também tinha feito quando eram condicionais multiline.
Inclusive o outro caso o comentário na Modal.tsx, condicional, que deveria ser inline, mas usada multiline!
…arogfn/issue172
Alecell
approved these changes
Dec 6, 2023
aalmeida00
approved these changes
Dec 6, 2023
|
Cria essa tarefa pra ajustar o eslint. LGTM por mim. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172
Feature
Adiciona um componente de Portal com a funcionalidade de renderizar algum componente flutuante.
Changelog
Visual evidences 🖼️
Checklist
Additional info
Aproveitei para mover o estilo de Acordeão que estava sendo reutilizado no SideBar e no ComposerEditor em um novo componente chamado AccordionTab. (A funcionalidade de esconder e mostrar o conteúdo também está funcionando)
Tive que ajustar a propriedade de width do InputSearch pois ela estava fixa, e acabava vazando do SideBar.