-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding a simple CLI #173
base: master
Are you sure you want to change the base?
Conversation
LGTM. Let's update dox a bit and then proceed with merging. |
Reviewpad Report
|
/reviewpad summarize |
AI-Generated Summary: This pull request includes 3 patches:
|
src/cli/index.ts
Outdated
.usage('swagger-codegen-ts -o <output_path> [flags] <path/to/spec.yaml>...') | ||
.option('baseDir', { | ||
alias: 'b', | ||
describe: 'base directory for <specs> and <outDir> paths', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really "outDir" or "baseDir", maybe a typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's correct if I understand you correctly
outDir
is relative to baseDir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After thinking a bit more on this, probably making outDir
relative to the baseDir
does not make much sense.
In the new commit this will be like this:
outDir
is relative to the cwd (unless an absolute path is given);- each
spec
is relative tobaseDir
if it is provided, otherwise relative to the cwd
AI-Generated Summary: This pull request includes several changes:
Overall, this PR focuses on improving the usability of the package by adding CLI usage instructions and updating the build configuration. |
AI-Generated Summary: This pull request includes changes related to updating the code generation tool and its documentation. It removes the Travis CI configuration, updates the README, adds a new CLI support, and makes several minor adjustments in |
Resolves #172