build(lint): migrate from tslint to eslint #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sergeymakoveev
commented
Sep 6, 2019
sergeymakoveev
commented
- migrate from tslint to eslint
- fix linter errors
raveclassic
requested review from
sutarmin and
raveclassic
and removed request for
sutarmin
|
Don't we want to remove anything related to |
|
tstint is now used by many developers and CI, so I did not delete tstint and its dependencies. |
|
Let's keep only one solution |
Done. |
raveclassic
suggested changes
Sep 9, 2019
raveclassic
previously approved these changes
Sep 9, 2019
raveclassic
approved these changes
Sep 11, 2019
raveclassic
pushed a commit
that referenced
this pull request
Sep 11, 2019
BREAKING CHANGE: tslint config was removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.