deliver script to download PDFs, file with list of Dashboards, to be … #1
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…updated, and README.md
rnapoles-rh
force-pushed
the
download-pdfs
branch
from
82b90d0 to
969aea0
Compare
There was a problem hiding this comment.
This looks basically ready to go. I think we need one more spin on the requirements.txt file, and there's one question on a detail.
You need to rebase your branch on the end of main again, and, for the moment, push your branch to the upstream repo so that the CI will run. (You'll probably need to open a new PR with the upstream branch -- I don't think there is any way to change the branch used by a PR -- and then just close this PR.)
| playwright==1.49.0 | ||
| pluggy==1.5.0 | ||
| pyee==12.0.0 | ||
| PySocks==1.7.1 | ||
| pytest==8.3.3 | ||
| pytest-base-url==2.1.0 | ||
| pytest-playwright==0.6.2 | ||
| python-slugify==8.0.4 | ||
| requests==2.32.3 | ||
| sniffio==1.3.1 | ||
| sortedcontainers==2.4.0 | ||
| text-unidecode==1.3 | ||
| tomli==2.2.1 | ||
| trio==0.27.0 | ||
| trio-websocket==0.11.1 | ||
| typing_extensions==4.12.2 | ||
| urllib3==2.2.3 | ||
| websocket-client==1.8.0 | ||
| wsproto==1.2.0 |
There was a problem hiding this comment.
Of this list, I think we need to specify only playwright. (The process of installing that will install its dependencies, so we don't need to list them here.)
Also, I think we need PyYAML, which isn't listed here.
|
|
||
| browser = playwright.chromium.launch(headless=False) |
There was a problem hiding this comment.
Shouldn't headless be set to True? (At least, when we're in production, I don't think we actually need to see what the tool is doing...right?)
…updated, and README.md