Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ruRU locale and refactoring localization logic #124

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ten-Do
Copy link

@Ten-Do Ten-Do commented Jan 21, 2025

Pull Request Summary

This pull request includes the following changes:

  1. Localization (ruRU):

    • Added Russian (ruRU) localization.
  2. Refactoring Localization Logic:

    • change enUs and en_US to enUS
    • Removed the locales file.
    • Moved all localization logic to the locales folder, where all localization files are now consolidated and assembled into an object of type AdmiralLocale.
    • Relocated the Logout button to the auth folder, as it seems to be a more appropriate location.
  3. Fixes for Previously Non-Localized Elements:

    • Addressed issues where certain elements could not be localized before, including:
      • Notifications for login success or failure.
      • Logout button text.
      • Label for OAuth.

@arturvolokhin
Copy link
Collaborator

Hello @Ten-Do ,

We would like to thank you for your contribution and the detailed pull request. Your changes and the refactoring of the localization logic are looking like they will bring significant improvements to the project.

Unfortunately, at the moment our developers are busy with other projects and can't review and test your PR immediately. However, we will make sure that they get to it as soon as possible. Your work is appreciated and we value the effort you have put into this.

Again, thank you for helping to make this package better. We will keep you updated as we move forward with the review process.

Best regards, dev.family

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants