Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support HTTP header Config for client #9

Closed
wants to merge 1 commit into from
Closed

Support HTTP header Config for client #9

wants to merge 1 commit into from

Conversation

xiaoyun94
Copy link
Contributor

@xiaoyun94 xiaoyun94 commented Feb 20, 2024 •
edited
Loading

Due to http proxy, i have to config Cookie to access the wss url

derhuerst
derhuerst requested changes Feb 20, 2024
View reviewed changes
Copy link
Owner

@derhuerst derhuerst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, I think it's a good feature proposal!

However, I would like to change the CLI and the code style.

cli/client.js Outdated Show resolved Hide resolved
cli/client.js Outdated Show resolved Hide resolved
cli/client.js Outdated Show resolved Hide resolved
client.js Outdated Show resolved Hide resolved
@xiaoyun94 xiaoyun94 force-pushed the master branch 2 times, most recently from 2c25e04 to 86baac3 Compare February 20, 2024 17:18
@xiaoyun94 xiaoyun94 requested a review from derhuerst February 20, 2024 17:19
derhuerst
derhuerst reviewed Feb 20, 2024
View reviewed changes
cli/client.js Outdated Show resolved Hide resolved
tunnel.js Outdated Show resolved Hide resolved
@xiaoyun94 xiaoyun94 requested a review from derhuerst February 21, 2024 15:18
@xiaoyun94
Copy link
Contributor Author

can u tell me what should i do to solve with requested changes

@xiaoyun94 xiaoyun94 force-pushed the master branch 2 times, most recently from fcb45e4 to 8c528ae Compare February 24, 2024 15:54
@derhuerst derhuerst closed this in 4e2ea0f Feb 25, 2024
@derhuerst
Copy link
Owner

Thanks! Published as [email protected]. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derhuerst derhuerst Awaiting requested review from derhuerst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoyun94 @derhuerst